From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
Cc: thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, jonathanh@nvidia.com,
arnd@arndb.de, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A
Date: Tue, 4 Oct 2022 13:05:04 +0200 [thread overview]
Message-ID: <98d3b42d-3f9f-9b6e-8c17-46deae4b4030@linaro.org> (raw)
In-Reply-To: <20221003170634.56jibls3xjxiiulg@wslaptop>
On 03/10/2022 19:06, Diogo Ivo wrote:
> On Fri, Sep 30, 2022 at 12:49:31PM +0200, Krzysztof Kozlowski wrote:
>>> + ts-reset-gpios:
>>> + maxItems: 1
>>> + description: |
>>> + Specifier for a GPIO connected to the touchscreen reset control signal.
>>> + The reset signal is active low.
>>
>> Isn't touchscreen a separate (input) device?
>
> Hello, thank you for the feedback.
>
> According to the downstream kernel's log, it seems like the panel and
> the touchscreen controller are considered to be embedded in the same unit
> (for example in [1]),
Downstream kernel is not a proof of proper description of hardware. If
downstream says orange is an apple, does it mean orange is really an
apple? No... Downstream creates a lot of junk, hacks and workarounds.
> with the touch input being transmitted via HID-over-I2C,
> and since I did not find any reset gpio handling in that driver I opted to
> include this reset here, unless there is a better way of going about this.
Instead it should be in touch screen device.
>
> Best regards,
>
> Diogo
>
> [1]: https://android.googlesource.com/kernel/tegra/+/bca61c34db9f72113af058f53eeb9fbd5e69a1d0
Where is the DTS of that device?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-04 11:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 17:04 [PATCH 0/4] Add JDI LPM102A188A display panel support Diogo Ivo
2022-09-29 17:04 ` [PATCH 1/4] dt-bindings: display: Add bindings for JDI LPM102A188A Diogo Ivo
2022-09-30 10:49 ` Krzysztof Kozlowski
2022-10-03 17:06 ` Diogo Ivo
2022-10-04 11:05 ` Krzysztof Kozlowski [this message]
2022-10-04 16:37 ` Diogo Ivo
2022-09-29 17:05 ` [PATCH 2/4] drm/tegra: dsi: Clear enable register if powered by bootloader Diogo Ivo
2022-09-30 11:11 ` Thierry Reding
2022-10-03 18:13 ` Diogo Ivo
2022-09-29 17:05 ` [PATCH 3/4] drm/panel: Add driver for JDI LPM102A188A Diogo Ivo
2022-09-29 17:05 ` [PATCH 4/4] arm64: dts: smaug: Add display panel node Diogo Ivo
2022-09-30 10:51 ` Krzysztof Kozlowski
2022-09-30 11:15 ` Thierry Reding
2022-09-30 11:20 ` Krzysztof Kozlowski
2022-09-30 21:14 ` Rob Herring
2022-10-01 9:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d3b42d-3f9f-9b6e-8c17-46deae4b4030@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).