From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 083A5CA0FE8 for ; Fri, 1 Sep 2023 08:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232644AbjIAIE7 (ORCPT ); Fri, 1 Sep 2023 04:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348583AbjIAIE6 (ORCPT ); Fri, 1 Sep 2023 04:04:58 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD8E10DE for ; Fri, 1 Sep 2023 01:04:54 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-500c63c9625so3108494e87.2 for ; Fri, 01 Sep 2023 01:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693555493; x=1694160293; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IzO9gCUfcK7k5IuvVe3uhn05iEMO5z76y81oJIjvpxQ=; b=JuUFwkXBhiBtLXWZzDSjP7DZkTsIF8yG2b1+ioWGL+ObGniRvouuKapBpBzqL24mCR 2s5f+ewDtenABFY5Cmjtu5bYLyMDTH87nnccvC2SmLNA/m+rVOLObtr3ZGe+TwIYur0f 5Ol+W7uFsWW+O8H+KZB+AYLE8zrFByn067Dq6U3g44ECrLrZiL2kQM8wuvYP9A3pFVr+ h42XGZQHJHH9oBAlQxVDJTkh/qF3VGKPaSzBmvu+z4dyqKb1TY6HDX8QK7T+6FnaNtQX bxqywon9+LDa8T7weLOzaJtXy6HoajqctcL47t0jfykPjLSFLkrWFHgfVypjpbFiOUi5 n37A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693555493; x=1694160293; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IzO9gCUfcK7k5IuvVe3uhn05iEMO5z76y81oJIjvpxQ=; b=Yl7HL8Logdzx+VJSgCodZJqOLKHDTKw03eS5LkeqtkjAj6ro03HugEwxoo387yPiQx cb0knxlkRO8qremfI1OEc0/eyXsmD8txGKoNZVhjU04Plx/L2CaM0RPhPElQQgTuET43 8uEKmBcVmKnqZinxCDPxWqDfD18NoH1VgfUeuOIFdVy9jY7h5+ZMINk0en2PL5rZ2zNn kenEF2cioY7TyXPhCz2zza/6kerzYQRD98xdO+31hFyJ9lSH3K5G5Gr5v6BRF0vnM90v pNvamRnShfygTqFYwajWCyiaNBdJperFKPrNPFAF8nvQOnAOAB1EF+90zrjxagjk2ApY BONA== X-Gm-Message-State: AOJu0YxCGVr3lruOPYZkwcnxHLRbJ0UIc+THZgVMyIIxClqPz7kuJsal o+pd25Esi4fTtQIuj0JAxhl757ANZ1panBxoe2I= X-Google-Smtp-Source: AGHT+IGD9kp6I2JS12SaZje0a91CCugy8xHNz6eemJbMlSkmb/3tNimG4/2DqOvk9/ZGpv/nHkUi0g== X-Received: by 2002:a19:2d17:0:b0:500:9a45:636 with SMTP id k23-20020a192d17000000b005009a450636mr951676lfj.13.1693555492923; Fri, 01 Sep 2023 01:04:52 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id bm26-20020a0564020b1a00b005288f0e547esm1777261edb.55.2023.09.01.01.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Sep 2023 01:04:52 -0700 (PDT) Message-ID: <99045d3e-53b4-dd75-fe57-9a3465d49b6c@linaro.org> Date: Fri, 1 Sep 2023 10:04:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/5] arm64: dts: qcom: apq8096-db820c: drop simple-bus from clocks Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd References: <20230324202244.744271-1-krzysztof.kozlowski@linaro.org> <20230324202244.744271-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2023 11:04, Dmitry Baryshkov wrote: > On Fri, 24 Mar 2023 at 22:23, Krzysztof Kozlowski > wrote: >> >> 'clocks' node is not a bus, but just a placeholder for clocks: >> >> apq8096-db820c.dtb: clocks: $nodename:0: 'clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' >> From schema: dtschema/schemas/simple-bus.yaml >> apq8096-db820c.dtb: clocks: xo-board: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], ... >> From schema: dtschema/schemas/simple-bus.yaml >> >> Signed-off-by: Krzysztof Kozlowski > > This patch broke audio support on DB820c. Now the divclk1 clock is not > registered, as drivers/clk/clk-gpio.c doesn't have CLK_OF_DECLARE(). > > Stephen, What would be the best way to fix this? Add CLK_OF_DECLARE > support to clk-gpio.c? Or simply move divclk1 from /clocks into a > separate device? > > What is the rule, which clock drivers must support such device-less > binding using /clocks/foo nodes? Uh, sorry for that, I think my patch is incomplete. I did not notice that not all clocks have CLK_OF_DECLARE. How about moving all the clocks out of "clocks" node to the root? Then they should be instantiated, regardless of having CLK_OF_DECLARE. Best regards, Krzysztof