From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/of: Make of_io_request_and_map() "name" argument optional
Date: Wed, 13 Jun 2018 08:53:59 +1000 [thread overview]
Message-ID: <9906dd0ed56e71468291ad68e24f43dd5d9b5269.camel@kernel.crashing.org> (raw)
In-Reply-To: <20180612221815.GA28761@rob-hp-laptop>
On Tue, 2018-06-12 at 16:18 -0600, Rob Herring wrote:
> On Tue, Jun 12, 2018 at 10:01:07AM +1000, Benjamin Herrenschmidt wrote:
> > These days of_address_to_resource() puts a reasonable name
> > in the resource struct, thus make the "name" argument an
> > optional override.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> >
> > Just something I noticed ... we should probably update the
> > callers to stop passing stupid names..
>
> Sounds like a coccinelle patch.
Quite possibly, though I'm absolutely not proficient with coccinelle :-)
> When do we need an actual name passed in? It does get exposed to
> userspace, but no one seemed to care when names changed from full path
> (which is commonly used) to just the node name.
Not sure, I had a look at the names looked rather random.
>
> Rob
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-06-12 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 0:01 [PATCH] drivers/of: Make of_io_request_and_map() "name" argument optional Benjamin Herrenschmidt
2018-06-12 22:18 ` Rob Herring
2018-06-12 22:53 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9906dd0ed56e71468291ad68e24f43dd5d9b5269.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).