From: "Heiko Stübner" <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: add support for Radxa ROCK Pi E v3.0
Date: Wed, 14 Aug 2024 13:30:46 +0200 [thread overview]
Message-ID: <9908246.lRi8OiJO2u@diego> (raw)
In-Reply-To: <20240814095727.1662908-1-naoki@radxa.com>
Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki:
> Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip
> RK3328 chip.
>
> [1] https://radxa.com/products/rockpi/pie
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> Changes in v4:
> - update compatible string for OpenWrt
> - drop A-b tag
> Changes in v3:
> - collect A-b tag
> Changes in v2:
> - fix typo in commit message
> - add missing --- in commit message
> - add new section instead of new item in rockchip.yaml
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 2ad835f4068e..1d426d4e1928 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -790,6 +790,11 @@ properties:
> - const: radxa,rockpi-e
> - const: rockchip,rk3328
>
> + - description: Radxa ROCK Pi E v3.0
> + items:
> + - const: radxa,rock-pi-e-v3
> + - const: rockchip,rk3328
> +
Please don't add a separate entry for the simple updated version.
Instead group it with the original Rock Pi e above.
For how to do it, look at the Radxa Zero 3w/3e .
next prev parent reply other threads:[~2024-08-14 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 9:57 [PATCH v4 1/2] dt-bindings: arm: rockchip: add support for Radxa ROCK Pi E v3.0 FUKAUMI Naoki
2024-08-14 9:57 ` [PATCH v4 2/2] arm64: dts: " FUKAUMI Naoki
2024-08-14 10:25 ` [PATCH v4 1/2] dt-bindings: arm: " FUKAUMI Naoki
2024-08-14 11:32 ` Heiko Stübner
2024-08-14 20:18 ` FUKAUMI Naoki
2024-08-14 11:30 ` Heiko Stübner [this message]
2024-08-14 20:04 ` FUKAUMI Naoki
2024-08-14 21:53 ` Heiko Stübner
2024-08-14 21:55 ` FUKAUMI Naoki
2024-08-14 15:48 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9908246.lRi8OiJO2u@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox