[PATCH 1/3] dt-bindings: clock: qcom,rpmcc: Add compatible for SM6375

[PATCH 1/3] dt-bindings: clock: qcom,rpmcc: Add compatible for SM6375

[Konrad Dybcio]

Add a compatible for RPMCC on SM6375.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
index 9d296b89a8d0..f22febdfdce7 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
@@ -43,6 +43,7 @@ properties:
           - qcom,rpmcc-sdm660
           - qcom,rpmcc-sm6115
           - qcom,rpmcc-sm6125
+          - qcom,sm6375-rpmcc
       - const: qcom,rpmcc
 
   '#clock-cells':
-- 
2.37.0

[PATCH 2/3] dt-bindings: clock: qcom: rpmcc: Add BIMC_FREQ_LOG

[Konrad Dybcio]

Add the missing definition for the aforementioned clock.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 include/dt-bindings/clock/qcom,rpmcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/qcom,rpmcc.h b/include/dt-bindings/clock/qcom,rpmcc.h
index 015db95303d1..c0ad624e930e 100644
--- a/include/dt-bindings/clock/qcom,rpmcc.h
+++ b/include/dt-bindings/clock/qcom,rpmcc.h
@@ -167,5 +167,6 @@
 #define RPM_SMD_CPUSS_GNOC_A_CLK		121
 #define RPM_SMD_MSS_CFG_AHB_CLK		122
 #define RPM_SMD_MSS_CFG_AHB_A_CLK		123
+#define RPM_SMD_BIMC_FREQ_LOG			124
 
 #endif
-- 
2.37.0

Re: [PATCH 2/3] dt-bindings: clock: qcom: rpmcc: Add BIMC_FREQ_LOG

[Stephen Boyd]

Quoting Konrad Dybcio (2022-07-16 12:27:13)
> Add the missing definition for the aforementioned clock.
> 

What does the bimc freq log do?

Re: [PATCH 2/3] dt-bindings: clock: qcom: rpmcc: Add BIMC_FREQ_LOG

[Konrad Dybcio]

On 19.07.2022 09:13, Stephen Boyd wrote:
> Quoting Konrad Dybcio (2022-07-16 12:27:13)
>> Add the missing definition for the aforementioned clock.
>>
> 
> What does the bimc freq log do?
It does not seem used by any driver downstream, not from a quick glance at
least. It is however exposed on the downstream kernel and here's what
debugfs has to say about it on mainline:

clk_accuracy:0
clk_duty_cycle:1/2
clk_enable_count:0
clk_max_rate:18446744073709551615
clk_min_rate:0
clk_notifier_count:0
clk_parent:xo_board
clk_phase:0
clk_prepare_count:0
clk_protect_count:0
clk_rate:1

Konrad 

Re: [PATCH 1/3] dt-bindings: clock: qcom,rpmcc: Add compatible for SM6375

[Krzysztof Kozlowski]

On 16/07/2022 21:27, Konrad Dybcio wrote:
> Add a compatible for RPMCC on SM6375.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> index 9d296b89a8d0..f22febdfdce7 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> @@ -43,6 +43,7 @@ properties:
>            - qcom,rpmcc-sdm660
>            - qcom,rpmcc-sm6115
>            - qcom,rpmcc-sm6125
> +          - qcom,sm6375-rpmcc

I am fine with it, although this contradicts a bit
https://lore.kernel.org/all/20220705161301.493364-1-krzysztof.kozlowski@linaro.org/

Would be nice to get Bjorn's opinion/preference on this.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: clock: qcom,rpmcc: Add compatible for SM6375

[Bjorn Andersson]

On Wed, Jul 20, 2022 at 08:30:13AM +0200, Krzysztof Kozlowski wrote:
> On 16/07/2022 21:27, Konrad Dybcio wrote:
> > Add a compatible for RPMCC on SM6375.
> > 
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> > ---
> >  Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> > index 9d296b89a8d0..f22febdfdce7 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> > @@ -43,6 +43,7 @@ properties:
> >            - qcom,rpmcc-sdm660
> >            - qcom,rpmcc-sm6115
> >            - qcom,rpmcc-sm6125
> > +          - qcom,sm6375-rpmcc
> 
> I am fine with it, although this contradicts a bit
> https://lore.kernel.org/all/20220705161301.493364-1-krzysztof.kozlowski@linaro.org/
> 
> Would be nice to get Bjorn's opinion/preference on this.
> 

While global consistency is nice, I think we should just stick with
qcom,rpmcc-<soc>, to keep this binding nice and tidy.

Regards,
Bjorn

> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> Best regards,
> Krzysztof