Re: [PATCH 1/3] dt-bindings: clock: qcom: document the Milos GX clock controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 02/04/2026 14:24, Luca Weiss wrote:
>>>> +  '#power-domain-cells':
>>>> +    const: 1
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>
>>> reg should be the second property, like you have it in "required" part.
>>> I guess you copied it from kaanapali-gxclkctl.yaml, so lesson - qcom
>>> bindings have acceptable quality, but not good enough to take as correct
>>> starting point.
>>>
>>
>> OTOH, why this entire binding cannot be squashed in Kaanapali one?
>> What's the difference?
> 
> There's no GMXC power domain on Milos. Apart from that they're
> compatible from a bindings perspective.

Ah, right, I missed only two items here.

> 
> However it can re-use include/dt-bindings/clock/qcom,kaanapali-gxclkctl.h
> because the GX_CLKCTL_GX_GDSC definition would be identical.

Indeed and you use the same driver, so the header can be re-used. This
should be explained in the commit msg.

> 
> And also the driver (which can be used as-is) would be identical. In
> that driver qcom,kaanapali-gxclkctl.h is used so it makes sense to keep
> with the kaanapali header, or not? Making a qcom,milos-gxclkctl.h with
> the same definition is not wanted?
> 
Best regards,
Krzysztof