From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add binding for spi-byte LED. References: <20190513193307.11591-1-oss@c-mauderer.de> <20190519212501.GC31403@amd> <1850ba07-2c0c-2624-4ff3-fd507e49439f@c-mauderer.de> From: Jacek Anaszewski Message-ID: <99283573-2711-08b6-b95e-27732c175bb4@gmail.com> Date: Mon, 20 May 2019 22:15:13 +0200 MIME-Version: 1.0 In-Reply-To: <1850ba07-2c0c-2624-4ff3-fd507e49439f@c-mauderer.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Christian Mauderer , Pavel Machek Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, Dan Murphy , Rob Herring , Mark Rutland List-ID: Hi Christian, On 5/20/19 7:19 PM, Christian Mauderer wrote: > On 19/05/2019 23:25, Pavel Machek wrote: >> Hi! >> >>> From: Christian Mauderer >>> >>> This patch adds the binding documentation for a simple SPI based LED >>> controller which use only one byte for setting the brightness. >>> >>> Signed-off-by: Christian Mauderer >>> --- >> >>> diff --git a/Documentation/devicetree/bindings/leds/leds-spi-byte.txt b/Documentation/devicetree/bindings/leds/leds-spi-byte.txt >>> new file mode 100644 >>> index 000000000000..28b6b2d9091e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/leds-spi-byte.txt >>> @@ -0,0 +1,44 @@ >>> +* Single Byte SPI LED Device Driver. >> >>> +The driver can be used for controllers with a very simple SPI protocol: >>> +- one LED is controlled by a single byte on MOSI >>> +- the value of the byte gives the brightness between two values (lowest to >>> + highest) >>> +- no return value is necessary (no MISO signal) >> >> I'd expect this file to be named acb-spi-led.txt, or something, and >> talk about that u-controller, not its device driver -- as devicetree >> binding describes hardware, not driver. >> >> But you already have an ack from rob, so... >> Pavel >> > > So basically it would have been better to move the description that I > added to the c-file as "supported devices" in the device tree file? > > With both commits already acked: Rob and Pavel: Should I change that? > > If you both say yes, I would rename the file in the binding like > suggested and move the detailed protocol description from the driver to > the binding. Let's not ramble on it. It is good as is. Patch set applied to the for-next branch of linux-leds.git. Thank you for your work. -- Best regards, Jacek Anaszewski