From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FDD30AD1A for ; Mon, 15 Jun 2026 10:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781521101; cv=none; b=A/UJita6kroEs3nMeM55T0Yst0yjEnSJ8CHNHi0Gzw/4Ujl6pd8p5i1jFdnX9CmfQBIfl0Dxo14mSPsE3/0w82cTcYEQMSd0JBCgFPiA+VKCtqoIafW9HDQHLYlTdYkz3SqavcRltLHAVpLVwFPX3GAyCfnRq7sKqUoijoGm1l0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781521101; c=relaxed/simple; bh=VjrgEW5Pqjix5ZZy/LLAPgYsKbIfPhYYjQJdMexb7fs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZLiRSICfueHoJfuqidJkG/p3ep+gTGpsUJxC/VzBMxylu57H3h8rQqXyQaG/OL0wjBRAVO4JU4SQo59cefsS9auzRNKfOt1mcVc/7esLGxDQKSH/b7HaobUkbNZYwPS+uaSIM0VF612WoD/5NtzpMnO65rD/g4UfQDvTlB/yScs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YlkDCYFM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YlkDCYFM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 101FD1F000E9; Mon, 15 Jun 2026 10:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781521099; bh=LuKeEn5cNI6llmnwlNvGXwwBfqGQwoSmAXWxDCHvQkE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=YlkDCYFMHSP92k1XPHrp4BoKUIvIxnDvbbeRBejCRdf9n8eMjgGjsLWbffXAX7pCM vw5T/uZ1hJ7zQwJFZSCpgvnRO9Hzz9MxdAz0bYTeNHGzenrdl8fvmHRF+TJe7VZVvb 1xIeMUJTlcEbkU4Uh/VHGoeu6uypJTu6VV8dsBGCvt7GMvdIxuhEGqhaRMRJtQJb7S tGOdAj2wA3atGWiOKCGXAopiPKOrupPjPaaPzvd4Zv3a8EGUtPfL1mXG6KJuKEucvG +X/f/UHosxm6Nnk5V9AkPMjRrEOmH3I4Kg2oE+nAww9tHra50L7orHoKDw6WlYs2A1 a1udBPQN1g7zw== Message-ID: <992b1fa0-650b-4a60-ad55-206cfcf1c892@kernel.org> Date: Mon, 15 Jun 2026 12:58:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] ASoC: dt-bindings: ES8389: Add members about HPF and clock To: Zhang Yi Cc: alsa-devel@alsa-project.org, broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org, tiwai@suse.com References: <241d0fab-26ea-4c06-9928-e256f2cc5d1c@kernel.org> <20260615101423.19781-1-zhangyi@everest-semi.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260615101423.19781-1-zhangyi@everest-semi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/06/2026 12:14, Zhang Yi wrote: >>>>> Yes, setting mclk-from-sclk does not affect the MCLK connection. >>>> >>>> I am asking about wiring of the device. If MCLK is used from SCLK, but >>>> SCLK is used as the internal clock, then how can you still have MCLK >>>> connected? >>> >>> If MCLK is derived from SCLK, whether the 'MCLK' pin on the device is >>> connected or not has no effect on operation. >> >> If MCLK is connected, why would you derive it from SCLK? That's the >> point - your clocks property already might be telling everything needed >> here. > > This is because sometimes the codec does not work properly > when using the MCLK provided by the CPU. OK. > >>>>>>> + >>>>>>> + everest,hpfl: >>>>>>> + $ref: /schemas/types.yaml#/definitions/uint8 >>>>>>> + description: >>>>>>> + the HPF value of ADCL. >>>>>> >>>>>> Is HPF value in dB? If so, use proper unit suffix and proper units. >>>>> >>>>> No, the values here correspond to the values in the registers. >>>>> The value is not in dB >>>> >>>> What are the meanings of the register values? >>> >>> The value of everest,hpfl is equal to the value of the corresponding register, >>> not the cutoff frequency of the HPF. >> >> You keep avoiding answers. >> >> I don't want you to encode standard units as register values. > > I think I understand what you mean. > Do you want me to enter the physical values in DTS and then convert them to register values in the code? If you have clear physical values then this should be rather used in DTS. Best regards, Krzysztof