Re: [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Fix reference USB device schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/08/2024 08:58, Alexander Stein wrote:
> An USB hub is not a HCD, but an USB device. Fix the referenced schema
> accordingly. Adjust example to keep it aligned to other schemas.
> 
> Fixes: bfbf2e4b77e27 ("dt-bindings: usb: Document the Microchip USB2514 hub")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> As this USB hub also can contain an USB (ethernet) sub device, I copied
> the subdevice part from usb-hcd.yaml.
> 
> I had to add 'additionalProperties: true' as well, because I got that warning
> upon dt_binding_check otherwise:


Thanks for fixing this.

>  
> +patternProperties:
> +  "^.*@[0-9a-f]{1,2}$":
> +    description: The hard wired USB devices
> +    type: object
> +    $ref: /schemas/usb/usb-device.yaml
> +    additionalProperties: true
> +
>  unevaluatedProperties: false
>  
>  examples:
> @@ -47,7 +54,7 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> -        usb-hub@1 {
> +        hub@1 {

This is not needed. Both are correct - usb-hub and hub. I prefer not to
rename all "phy" nodes to "usb-phy" and vice versa.

Rest is good, so with dropping this renaming hunk:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof