From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56BC4C433EF for ; Fri, 29 Apr 2022 06:29:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354471AbiD2Gcs (ORCPT ); Fri, 29 Apr 2022 02:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238357AbiD2Gcq (ORCPT ); Fri, 29 Apr 2022 02:32:46 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C513B9F0E for ; Thu, 28 Apr 2022 23:29:29 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id kq17so13555425ejb.4 for ; Thu, 28 Apr 2022 23:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=MWHSWTEKcv7Xi6sCry02KvjP0oi7MJ00AsTeELKYR1k=; b=QFNUUb7tg4MO3nPhOkcmFLcYBzSw8R4q4NyB2kULHhHKCiwDpwjty4GzN+1qHUVWXo fy/jgch+A3d/a/EsdCQt+WpAjKkOil9mJn0LhC+0+msC2IKjNqHyVzrE8sCRkUww67pG /WQXyoc2hMm6sFjyP9LRtNhazv/0fiQE1nHfG7sGYtcdEMrDVNkxPB3RdQruO3rbwogU jZRFUrgt419FWZ1gSUhPzs5kBvpi7sV8xWnL0mDAPl99Jx5VBLUOkKtQkcPLNC4ql919 fl+IbUGz3T/k/cl9BWupoSBSyvEUdC39A2msPYGNS1W6/ENMH78IwgD3Tdad+P6OumoM fOqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=MWHSWTEKcv7Xi6sCry02KvjP0oi7MJ00AsTeELKYR1k=; b=eylcXW8NgCHUntOvBqOy2QJ8LbCfxP6J/n8p1UOmpV4IW3u5iftQg7ROZwfswH1Hoh FVs39y/jKI7ryRDWYowSOhfIS2SRxlTUKNsC6hUwBnLVpKu5wVIhBe1zotqVmhnIPD11 7PFw39ONER6kjHEe534p/RosO2fYClZP4MlGxp2tdn/HW90NTbDhbKZkRiCfQCDdc4/0 8t1cuC6aTP19MQWMjE92q9SX3KUq65rt5Xe0aX+dN/RKkecSxkW3lThd46HsKoy+v7vP G414dazaBarfE2cUbecESKd8V6rlV3hn/2E2oxbcuzi4BXE9KBdEk5o2qRmPPR34COxV NcFQ== X-Gm-Message-State: AOAM530Ige/I6jd7r1jGJNOSBr8/U5Vk/Z1Epg1bbIO3rzFv0EMZaCAU +woQiRuHfSc7t58oLuGLoM4RPA== X-Google-Smtp-Source: ABdhPJwF7kYhyBa2oQUWsOUhyejHYRH7OCesXxrrQ17b6ikVFNcVtOgzey85fp+uzN1oMC+KLH73MA== X-Received: by 2002:a17:907:8a10:b0:6f0:51c6:3cee with SMTP id sc16-20020a1709078a1000b006f051c63ceemr34819381ejc.259.1651213768126; Thu, 28 Apr 2022 23:29:28 -0700 (PDT) Received: from [192.168.0.168] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id hz13-20020a1709072ced00b006f3ef214db2sm333250ejc.24.2022.04.28.23.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 23:29:27 -0700 (PDT) Message-ID: <993d74fa-be5b-6db2-6bba-2323de7757f3@linaro.org> Date: Fri, 29 Apr 2022 08:29:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 05/11] dt-bindings: serio: add Arm PL050 DT schema Content-Language: en-US To: Andre Przywara Cc: Rob Herring , Krzysztof Kozlowski , Liviu Dudau , Robin Murphy , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dmitry Torokhov , linux-input@vger.kernel.org References: <20220427112528.4097815-1-andre.przywara@arm.com> <20220427112528.4097815-6-andre.przywara@arm.com> <55574426-df20-cdd7-c97d-092726981a42@linaro.org> <20220428182708.0c1065f8@donnerap.cambridge.arm.com> From: Krzysztof Kozlowski In-Reply-To: <20220428182708.0c1065f8@donnerap.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/04/2022 19:27, Andre Przywara wrote: >>> + clock-names: >>> + items: >>> + - const: KMIREFCLK >> >> lowercase letters only > > I am afraid this ship has sailed: the various DTs in the kernel tree use > it in that way, and the Linux driver insists on that spelling. The driver is coming from ancient times, so it is understandable it has some old coding style. But it definitely not sailed away. :) > So by > changing this we would break both the existing DT's compliance and also > existing Linux kernels. > So is lowercase something that is mandated by DT schema, or can we just > make an exception here? This uppercase clock name affects even ARM64 devices, so it seems the device is still being used. Therefore I propose to add new clock name, old as deprecated and support both in the driver: kmi->clk = clk_get(&dev->dev, "kmirefclk"); if (IS_ERR(kmi->clk)) { kmi->clk = clk_get(&dev->dev, "KMIREFCLK"); and convert the DTS as well later on. Best regards, Krzysztof