From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings Date: Tue, 6 Jun 2017 16:01:45 +0300 Message-ID: <99525652-0270-4eb0-73bc-c65ac51bc39e@ti.com> References: <1496405096-18275-1-git-send-email-boris.brezillon@free-electrons.com> <1496405096-18275-2-git-send-email-boris.brezillon@free-electrons.com> <62284d00-c204-dc2e-a780-0357b2094b62@ti.com> <20170606143723.52962a22@bbrezillon> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CaAUlSHmf0NjHnCpWJVjoEN5tedxwHoEm" Return-path: In-Reply-To: <20170606143723.52962a22@bbrezillon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boris Brezillon Cc: David Airlie , Daniel Vetter , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Archit Taneja , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Cyprian Wronka , Thomas Petazzoni , Pawel Moll , Ian Campbell , Simon Hatliff , Alan Douglas , Rob Herring , Kumar Gala , Maxime Ripard , Richard Sproul , Neil Webb List-Id: devicetree@vger.kernel.org --CaAUlSHmf0NjHnCpWJVjoEN5tedxwHoEm Content-Type: multipart/mixed; boundary="23EnX5mkJjVugh3OpA7j0TrRLG9qvSrei"; protected-headers="v1" From: Tomi Valkeinen To: Boris Brezillon Cc: David Airlie , Daniel Vetter , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Archit Taneja , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Cyprian Wronka , Thomas Petazzoni , Pawel Moll , Ian Campbell , Simon Hatliff , Alan Douglas , Rob Herring , Kumar Gala , Maxime Ripard , Richard Sproul , Neil Webb Message-ID: <99525652-0270-4eb0-73bc-c65ac51bc39e-l0cyMroinI0@public.gmane.org> Subject: Re: [PATCH v2 2/2] dt-bindings: drm/bridge: Document Cadence DSI bridge bindings References: <1496405096-18275-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> <1496405096-18275-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> <62284d00-c204-dc2e-a780-0357b2094b62-l0cyMroinI0@public.gmane.org> <20170606143723.52962a22@bbrezillon> In-Reply-To: <20170606143723.52962a22@bbrezillon> --23EnX5mkJjVugh3OpA7j0TrRLG9qvSrei Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 06/06/17 15:37, Boris Brezillon wrote: > Hi Tomi, >=20 > On Tue, 6 Jun 2017 15:30:26 +0300 > Tomi Valkeinen wrote: >=20 >> On 02/06/17 15:04, Boris Brezillon wrote: >>> Document the bindings used for the Cadence DSI bridge. >>> >>> Signed-off-by: Boris Brezillon >>> --- >>> .../bindings/display/bridge/cdns,dsi.txt | 55 ++++++++++++= ++++++++++ >>> 1 file changed, 55 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/bridge/= cdns,dsi.txt >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,ds= i.txt b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt >>> new file mode 100644 >>> index 000000000000..770c5c5b1e93 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt >>> @@ -0,0 +1,55 @@ >>> +Cadence DSI bridge >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> + >>> +The Cadence DSI bridge is a DPI to DSI bridge supporting up to 4 DSI= lanes. >>> + >>> +Required properties: >>> +- compatible: should be set to "cdns,dsi". >>> +- reg: physical base address and length of the controller's register= s. >>> +- interrupts: interrupt line connected to the DSI bridge. >>> +- clocks: DSI bridge clocks. >>> +- clock-names: must contain "pclk" and "sysclk". =20 >> >> clock-names doesn't match the example below. >=20 > Indeed. I'll fix the example. >=20 >> >>> +- phys: phandle link to the MIPI D-PHY controller. >>> +- phy-names: must contain "dphy". >>> +- #address-cells: must be set to 1. >>> +- #size-cells: must be set to 0. >>> + >>> +Required subnodes: >>> +- ports: Ports as described in Documentation/devicetree/bindings/gra= ph.txt. >>> + Currently contains a single input port at address 0 representing t= he DPI >>> + input. Other ports will be added later to support the SDI inputs. = =20 >> >> Typo with "SDI". >=20 > No, the 2nd and 3rd input ports are really called SDI. Here > is the datasheet description: >=20 > " > SDI:=20 > Serial Display Interface - this is the name of the block that is built > to interface the Display application processor to the DSI link. This is= > a proprietary interface. > " Ok. Well, I think that's a bit pointless comment in the binding doc, it'll only confuse =3D). Describe what the current binding is, not what might be added later (but that can be mentioned in the commit desc if you want). Tomi --23EnX5mkJjVugh3OpA7j0TrRLG9qvSrei-- --CaAUlSHmf0NjHnCpWJVjoEN5tedxwHoEm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZNqe6AAoJEPo9qoy8lh71kg4QAJQDYsjzeTlMuyr1g47RDNj7 +Ud6cv+7ZDddLKM6xaKGR9n+jX0cuPKys67jZgj4LPm/s6cS0Lc3LMhMA3qaPCeZ X8U5ef6QC2QtRPhlVpdeYYNCXqdj4spKmU3lcF8h+W1j+sJuOvLWSFFflWtXPTg8 kObbL8JKmcb4puDsOQ5SE8hv5W9rPxbZvPOTAlOXm7nDZAdCXZEANtxf+OS/s45L ysTtUl+xcZXjIuX+DQNjIqZy9VheJD98+XNuqbLWJIng9Z9HQLUDz3d+/d4EBC4p coCyCu1S6c9YgaY8mGcKCHylvHzFCxtZGNrQ1twf9DOzGXfO+ru5k18+OrynrKwQ W5ZOIRNv6xm265ZNfHZH2rVNBAmhdqZBme9faze6V8WLrMQeUojLZG1pd83Efl6O N92ueJr7jy38EYT3Q0ChIvTniL7ElHOBfC7i9jO/TpZSIXY7CZ1XBLVdYLl9Ro1b +XNK6BArtrhVP5giWq0nt9NgAkgUE/WkZQ8bsPOBWaD3ymJ6Nop0030OHUpE8MA6 7vLuwWa0KfogCcBN8DM/PzxceQBCDVPDFd+hfjWuimtpwN+B0AwH936N+v3Pkoxj V1EeX+5VpeNJVuiCie6/8vFTit7QJbby6E3wLXzRF2qUAqjqlMuNJ+j8xFQ+87Zm ApPiT65r6/Lu6Ks3rQ3n =PyYY -----END PGP SIGNATURE----- --CaAUlSHmf0NjHnCpWJVjoEN5tedxwHoEm-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html