From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A5F4101E6; Sun, 20 Jul 2025 12:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753014385; cv=none; b=Cj1aO1XEjXt5BG0SBgk7m410s8bjwS4vvUe4p5wjSqhiUx61eQ7e5hPVgdBPdB3L+Fud7nLcZN6r9nJV7bYRTGnTM22+1qvrRqtuZl5k8C8cNSn4CbTxgKTa/aZnU8RY2VymXWCzI0D6SyZPAgEIhsKMdHjw7Wbh0OobhYgOVTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753014385; c=relaxed/simple; bh=7fG1ZiX1kVoYPnjokhnLvlTdKwDkkEtf2WSeMJ/wqZY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AE1HgPm2qDux/7pN7DUyysXz8O7MLrMneC9r4kk3kqA7L1pabztkBbpr5CgBjWZzxdS4Is5d+2Mz70K+xdfsmRUvCTBQ0AOgnaff/Y2FYLrdB5gUmrSXkTIM898dEegq5GCZdPWjP87bb0kr0R1+yI0JVMEpLHz88SLVzY3BaP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=krEhdMlL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="krEhdMlL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91BFDC4CEE7; Sun, 20 Jul 2025 12:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753014385; bh=7fG1ZiX1kVoYPnjokhnLvlTdKwDkkEtf2WSeMJ/wqZY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=krEhdMlLaqBd2zE/tloojMtkv+FGoTCF/y4/yyAd/eHosmUkraXur0gyeZH72nSRQ l5xV+CqSvvQX+s9G21P51NlHbpnL5aJ03geKtYvG3YQ/0cWLETN5FNntAnEQgapm4c pm94mtrqZxDdl0TJUQQFy3O0R4r9ljEQ18OHsOY00oAGTVEF3YoQV2zRapgB2C8ivi H6eWfY0lIWu6GiMYwXoFBUYOrkceFwPedb+Wf58CAoDlWw77SJTUtaL57Q28mwb49Q 4BRkgpwQR5cAQfMmtZ27USJoUoc/vBrh6wjAEBotcJC1AOPYALvOVDzs2sovlD+DLR sp4HU4rbEGC8A== Message-ID: <9966b9e4-399b-4446-81e4-15daf9acbff7@kernel.org> Date: Sun, 20 Jul 2025 14:26:19 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/12] dt-bindings: display: sprd: adapt for UMS9230 support To: =?UTF-8?Q?Otto_Pfl=C3=BCger?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Orson Zhai , Baolin Wang , Chunyan Zhang , Kevin Tang Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250719-ums9230-drm-v1-0-e4344a05eb3d@abscue.de> <20250719-ums9230-drm-v1-1-e4344a05eb3d@abscue.de> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250719-ums9230-drm-v1-1-e4344a05eb3d@abscue.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19/07/2025 14:09, Otto Pflüger wrote: > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > index 4ebea60b8c5ba5f177854e3a8d89e93e7304e18b..6fedb6e508b247eb71da17ced589b8ed09085592 100644 > --- a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dpu.yaml > @@ -16,7 +16,12 @@ description: | > > properties: > compatible: > - const: sprd,sharkl3-dpu > + oneOf: > + - items: > + - enum: > + - sprd,ums9230-dpu > + - const: sprd,sharkl3-dpu > + - const: sprd,sharkl3-dpu > > reg: > maxItems: 1 > @@ -25,12 +30,15 @@ properties: > maxItems: 1 > > clocks: > - minItems: 2 > + minItems: 1 This is wrong. You miss maxItems. I will fix existing bindings. > > clock-names: > - items: > - - const: clk_src_128m > - - const: clk_src_384m > + oneOf: > + - items: > + - const: clk_src_128m > + - const: clk_src_384m > + - items: > + - const: enable > > power-domains: > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > index bc5594d18643010b91376c92a8f235a522d7dc3d..8438d2da0a4277db03e30b13cb270684c0c360cb 100644 > --- a/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,sharkl3-dsi-host.yaml > @@ -11,7 +11,9 @@ maintainers: > > properties: > compatible: > - const: sprd,sharkl3-dsi-host > + enum: > + - sprd,sharkl3-dsi-host > + - sprd,ums9230-dsi-host > > reg: > maxItems: 1 > @@ -23,8 +25,11 @@ properties: > minItems: 1 > > clock-names: > - items: > - - const: clk_src_96m > + oneOf: > + - items: > + - const: clk_src_96m > + - items: > + - const: enable Why this is completely different clock? How same class device could have completely different clock INPUT? > > power-domains: > maxItems: 1 > Best regards, Krzysztof