From: Dragan Simic <dsimic@manjaro.org>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, macromorgan@hotmail.com, jonas@kwiboo.se,
andyshrk@163.com, liujianfeng1994@gmail.com, tim@feathertop.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: arm: rockchip: add Radxa ROCK 5C Lite
Date: Wed, 11 Dec 2024 08:14:00 +0100 [thread overview]
Message-ID: <99758008e8501d799c2a93e192645590@manjaro.org> (raw)
In-Reply-To: <FE22A7AEB0707DE7+903efcab-b291-4a12-a9a5-ba1cc3658016@radxa.com>
On 2024-12-11 07:44, FUKAUMI Naoki wrote:
> On 12/11/24 15:36, Dragan Simic wrote:
>> On 2024-12-11 07:09, FUKAUMI Naoki wrote:
>>> The Radxa ROCK 5C Lite uses a different SoC (RK3582) compared to the
>>> Radxa ROCK 5C (RK3588S2), but the two are compatible from a software
>>> perspective.
>>>
>>> Fixes: df4e08a5eed1 ("dt-bindings: arm: rockchip: add Radxa ROCK 5C")
>>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> index 753199a12923..2254ee079094 100644
>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> @@ -895,7 +895,7 @@ properties:
>>> - const: radxa,rock-5b
>>> - const: rockchip,rk3588
>>>
>>> - - description: Radxa ROCK 5C
>>> + - description: Radxa ROCK 5C/5C Lite
>>> items:
>>> - const: radxa,rock-5c
>>> - const: rockchip,rk3588s
>>
>> I think it would be better to use "rockchip,rk3582" here, to allow
>> us to possibly use that information later. For example, we might
>> want to be able to recognize RK3582-based boards in U-Boot without
>> the need to look into the e-fuses at some point, for which purpose
>> having a clear designator in the DT would fit perfectly.
>
> It may be okay to introduce "rockchip,rk3582", but reading e-fuse is
> still required in U-Boot because which unit (cpu coreX, gpu, etc) is
> broken cannot be determined without reading e-fuse at run-time.
Sure, but I think it would be rather bad to miss this opportunity
to introduce a clear DT designator for RK3582-based boards. It's
better to have the designator unused, than to bang our heads later,
if we conclude that we need it at some point. :)
>> As a reminder, using "rockchip,rk3582" would also require a small
>> addition to drivers/irqchip/irq-gic-v3-its.c.
prev parent reply other threads:[~2024-12-11 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 6:09 [PATCH] dt-bindings: arm: rockchip: add Radxa ROCK 5C Lite FUKAUMI Naoki
2024-12-11 6:36 ` Dragan Simic
2024-12-11 6:44 ` FUKAUMI Naoki
2024-12-11 7:02 ` FUKAUMI Naoki
2024-12-11 7:15 ` Dragan Simic
2024-12-11 7:14 ` Dragan Simic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99758008e8501d799c2a93e192645590@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
--cc=tim@feathertop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox