From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9300F1118E for ; Fri, 13 Oct 2023 09:53:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PGKX9A/a" Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17DF6B7 for ; Fri, 13 Oct 2023 02:53:37 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-53e16f076b3so2875121a12.0 for ; Fri, 13 Oct 2023 02:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697190815; x=1697795615; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WkuVxbIEDiPcXFcI1G0VHHSKRSTqjnTTd0Ixg+X9Clo=; b=PGKX9A/a2KHJrWae4tJb/ZNjmA4lilvJgk6ZUAkEdGr7pYJfSqikTwpelQLkXYdTgZ TYo2LegV9UNaFSqdZ41HMvcCuZOHO9IQqaVHo3re1MhQDAKYgtHKeQBN12j5J21g9xMy dqM7PMLxFj9Zek633UWn3VzP64V46GphkN2r4KSx75bgOj5hT0NzQO09j4LlZ54t1wev 5H5Jcgu0vs64X1cJLdsog0S5nbiYlt7Od8DFVyS7TOUYD6UFMjqNbWXBSU47Nks52zZc JNHDWA850WH4wZcZcW/pIbBN4gLtkAN1SxRARptXL6IvFI9bb+Dv6lRRANU0pFArzSuw EC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697190815; x=1697795615; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WkuVxbIEDiPcXFcI1G0VHHSKRSTqjnTTd0Ixg+X9Clo=; b=tEft6bKd+W/ZLBEGhdYyurltkdf4grot78Pj9eDCO1I3i/5otDOiFUFRxbTK8HVVqk raVhj2v1zPoK5QWiclfekz4wGJyuV3ZaE8pQUlCfLXABhP9mRKC1vAzLXEpknIYfDJjA aCZazGxzshrelEN0ZtC7xUiUoHJAO459mo4Wi22LqYs8c46Hyn+pEqfcENoc0wyQwL9t FGf5Orh2DiJn8ICGobBbcTKrOnAlyZQ6oK83D9DmxwvhAZ/hGBe7kcjiDNEPQWJNr4jl ZamkKS+u3XCsutNXSa0sHLkGRXMxy0cUAQAG2L6cZWAz0BpGTAdUZWBVndC6z/vf1bdN 9Uyw== X-Gm-Message-State: AOJu0YwF3/kq+lpu7vV99NF4wX6Gxgyco1p4JQGLVaSkch2gbvi416lt aIJAOZeHBVd+ndA2o01zIrb/Qg== X-Google-Smtp-Source: AGHT+IGjNeXVilC+CrFYPS0vWgxr62tccKu1v1YBauL0P3QvzaLroanfvTZ4YXInxShyHL84Pi653A== X-Received: by 2002:a17:907:61a8:b0:9bd:81c3:2a85 with SMTP id mt40-20020a17090761a800b009bd81c32a85mr5133624ejc.32.1697190815507; Fri, 13 Oct 2023 02:53:35 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id n12-20020a170906378c00b0099d45ed589csm12172789ejc.125.2023.10.13.02.53.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 02:53:35 -0700 (PDT) Message-ID: <9996a912-7b4e-4247-bb8a-716782fbcc2a@linaro.org> Date: Fri, 13 Oct 2023 11:53:33 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] dt-bindings: adc: provide max34408/9 device tree binding document Content-Language: en-US To: Jonathan Cameron Cc: Ivan Mikhaylov , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20231007234838.8748-1-fr0st61te@gmail.com> <20231007234838.8748-2-fr0st61te@gmail.com> <20231010154042.2ef667b2@jic23-huawei> <383064a5b0863a4a616cd60cff8d4bc18e397fd7.camel@gmail.com> <20231012084052.504ac930@jic23-huawei> <20231013091952.00002573@Huawei.com> <2eafa89c-7c95-4bc1-85cb-a6d7417dcea8@linaro.org> <20231013100930.000043b2@Huawei.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231013100930.000043b2@Huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 13/10/2023 11:09, Jonathan Cameron wrote: >>>>>>>> +  shtdn-enable-gpios:  >>>>>>> >>>>>>> I guess the review crossed with you sending v5.  There is some >>>>>>> feedback on v4 you need >>>>>>> to address here.  >>>>>> >>>>>> Jonathan, I thought I did, I've changed ena to powerdown-gpios from >>>>>> Krzysztof's comments but about this one pin I'm still not sure, it >>>>>> looks like *-enable-gpios (like in *-enable-gpios pins in >>>>>> iio/frequency/adi,adf4377.yaml) pin or is it not? Or maybe any >>>>>> other >>>>>> suggestions about naming of this one? >>>>>> >>>>>> Thanks. >>>>> >>>>> shutdown-gpios and make the sense (active high / low) such that >>>>> setting >>>>> it results in teh device being shut down. >>>>> Or treat it as an enable and enable-gpios >>>>> >>>>> Something that indicates both shutdown and enable is confusing ;) >>>>> >>>>> Jonathan >>>> >>>> >>>> Jonathan, then I make these changes: >>>> >>>> powerdown-gpios: -> output-enable: >>> Needs to retain the gpios bit as we want the standard gpio stuff to pick >>> them up. I'm not that keen on output-enable-gpios though. The activity >>> here is very much 'shutdown because of error or not enabled' I think. >>> So perhaps we flip the sense and document that it needs to be active low? >>> >>>> shtdn-enable-gpios: -> enable-gpios: >>>> >>>> Is it ok? >>> >>> Conor, Rob, Krzysztof - you probably have a better insight into this than >>> I do. >>> >> >> "enable-gpios" are for turning on a specific feature, not powering >> on/off entire device. For example to enable regulator output. >> >> "powerdown-gpios" are for turning device on/off. >> >> I don't know what do you have in your device. > Ok. Sounds like that what is enable-gpios above should be shutdown-gpios. shutdown-gpios sounds exactly the same as powerdown-gpios and it is already used in exactly same context. > The other case is a device output indicating whether the device is > shutdown. That can happen because it was told to do so (via the other gpio), > or because it is in an error state. What's a good naming convention for that? There is no convention and I did not see such case so far. powerdown-status-gpios? powerdown-state-gpios? Best regards, Krzysztof