Devicetree
 help / color / mirror / Atom feed
From: Suraj Sonawane <surajsonawane0215@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add ext_mclk1_c
Date: Sun, 22 Nov 2026 22:52:36 +0530	[thread overview]
Message-ID: <9997e6c6-2e5e-4314-88b2-a8547ab035f2@gmail.com> (raw)
In-Reply-To: <20261116-nondescript-buffalo-of-whirlwind-6a5008@quoll>



On 16/11/26 18:10, Krzysztof Kozlowski wrote:
> On Sun, Nov 15, 2026 at 11:12:36PM +0530, Suraj Sonawane wrote:
>> LPASS LPI gpio5 can mux EXT_MCLK1_C. The SC7280 driver names that
>> function ext_mclk1_c, matching SC8280XP, but the binding enum does
> 
> I do not see it in the driver, so are you sure you used correct reason
> for the patch? Mentioning driver means you document existing ABI being
> used.
You are correct, thank you. In mainline, gpio5 in
drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c is currently:

   LPI_PINGROUP(5, 12, swr_rx_data, _, _, _),

so ext_mclk1_c is not implemented for SC7280 yet. I described it
wrongly as existing ABI.

 >> not allow it.
 >
 > Entire sentence is clear here - there is ABI and binding does not allow
 > it. Please point me to that implementation.

There is no such implementation in SC7280. The same mux position is
exposed as ext_mclk1_c on SC8280XP, in
drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c:

   LPI_PINGROUP(5, 12, swr_rx_data, ext_mclk1_c, qua_mi2s_data, _),

On Vicharak's Axon Mini SBC (QCS6490, sc7280-compatible LPI) we need 
LPASS gpio5 as
EXT_MCLK1_C for the audio codec MCLK. Patch 2/2 adds ext_mclk1_c to the
SC7280 LPI pinctrl driver, and patch 1/2 updates the binding so
function = "ext_mclk1_c" is valid.

I will send a v3 with a corrected commit message that says we are adding
the missing function and binding, not documenting pre-existing ABI.
Thanks,
Suraj

  reply	other threads:[~2026-11-22 17:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 17:42 [PATCH v2 0/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c Suraj Sonawane
2026-11-15 17:42 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: " Suraj Sonawane
2026-11-16 12:40   ` Krzysztof Kozlowski
2026-11-22 17:22     ` Suraj Sonawane [this message]
2026-11-15 17:42 ` [PATCH v2 2/2] pinctrl: qcom: sc7280-lpass-lpi: add ext_mclk1_c function Suraj Sonawane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9997e6c6-2e5e-4314-88b2-a8547ab035f2@gmail.com \
    --to=surajsonawane0215@gmail.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox