devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
@ 2023-11-16 13:09 Rafał Miłecki
  2023-11-16 13:09 ` [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename Rafał Miłecki
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Rafał Miłecki @ 2023-11-16 13:09 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno, Matthias Brugger, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Sam Shih, Frank Wunderlich, devicetree, linux-arm-kernel,
	linux-mediatek, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

This fixes SPI setup and resolves following validation errors:
arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtb: spi_nand@0: Unevaluated properties are not allowed ('spi-rx-buswidth', 'spi-tx-buswidth' were unexpected)
        from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
arch/arm64/boot/dts/mediatek/mt7986b-rfb.dtb: spi_nand@0: Unevaluated properties are not allowed ('spi-rx-buswidth', 'spi-tx-buswidth' were unexpected)
        from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#

Fixes: 885e153ed7c1 ("arm64: dts: mt7986: add spi related device nodes")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 4 ++--
 arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
index 3ef371ca254e..bcb3ebb85d70 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
@@ -241,8 +241,8 @@ spi_nand: spi_nand@0 {
 		compatible = "spi-nand";
 		reg = <0>;
 		spi-max-frequency = <10000000>;
-		spi-tx-buswidth = <4>;
-		spi-rx-buswidth = <4>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
index dde190442e38..48fe50e67177 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
@@ -156,8 +156,8 @@ spi_nand: spi_nand@0 {
 		compatible = "spi-nand";
 		reg = <0>;
 		spi-max-frequency = <10000000>;
-		spi-tx-buswidth = <4>;
-		spi-rx-buswidth = <4>;
+		spi-tx-bus-width = <4>;
+		spi-rx-bus-width = <4>;
 	};
 };
 
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
  2023-11-16 13:09 [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties Rafał Miłecki
@ 2023-11-16 13:09 ` Rafał Miłecki
  2024-01-03 13:54   ` AngeloGioacchino Del Regno
  2024-01-03 13:55 ` [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties AngeloGioacchino Del Regno
  2024-01-22  9:09 ` Matthias Brugger
  2 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2023-11-16 13:09 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno, Matthias Brugger, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Sam Shih, Frank Wunderlich, devicetree, linux-arm-kernel,
	linux-mediatek, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

This fixes following validation errors:
arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtb: spi_nand@0: $nodename:0: 'spi_nand@0' does not match '^(flash|.*sram|nand)(@.*)?$'
        from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
arch/arm64/boot/dts/mediatek/mt7986b-rfb.dtb: spi_nand@0: $nodename:0: 'spi_nand@0' does not match '^(flash|.*sram|nand)(@.*)?$'
        from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#

Fixes: 885e153ed7c1 ("arm64: dts: mt7986: add spi related device nodes")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 3 ++-
 arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
index bcb3ebb85d70..2f884c24f1eb 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
@@ -237,7 +237,8 @@ &spi0 {
 	pinctrl-0 = <&spi_flash_pins>;
 	cs-gpios = <0>, <0>;
 	status = "okay";
-	spi_nand: spi_nand@0 {
+
+	spi_nand: flash@0 {
 		compatible = "spi-nand";
 		reg = <0>;
 		spi-max-frequency = <10000000>;
diff --git a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
index 48fe50e67177..57dcaeef31d7 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
@@ -152,7 +152,8 @@ &spi0 {
 	pinctrl-0 = <&spi_flash_pins>;
 	cs-gpios = <0>, <0>;
 	status = "okay";
-	spi_nand: spi_nand@0 {
+
+	spi_nand: flash@0 {
 		compatible = "spi-nand";
 		reg = <0>;
 		spi-max-frequency = <10000000>;
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
  2023-11-16 13:09 ` [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename Rafał Miłecki
@ 2024-01-03 13:54   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-03 13:54 UTC (permalink / raw)
  To: Rafał Miłecki, Matthias Brugger, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Sam Shih, Frank Wunderlich, devicetree, linux-arm-kernel,
	linux-mediatek, Rafał Miłecki

Il 16/11/23 14:09, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes following validation errors:
> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtb: spi_nand@0: $nodename:0: 'spi_nand@0' does not match '^(flash|.*sram|nand)(@.*)?$'
>          from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
> arch/arm64/boot/dts/mediatek/mt7986b-rfb.dtb: spi_nand@0: $nodename:0: 'spi_nand@0' does not match '^(flash|.*sram|nand)(@.*)?$'
>          from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
> 
> Fixes: 885e153ed7c1 ("arm64: dts: mt7986: add spi related device nodes")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
  2023-11-16 13:09 [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties Rafał Miłecki
  2023-11-16 13:09 ` [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename Rafał Miłecki
@ 2024-01-03 13:55 ` AngeloGioacchino Del Regno
  2024-01-22  9:09 ` Matthias Brugger
  2 siblings, 0 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-03 13:55 UTC (permalink / raw)
  To: Rafał Miłecki, Matthias Brugger, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Sam Shih, Frank Wunderlich, devicetree, linux-arm-kernel,
	linux-mediatek, Rafał Miłecki

Il 16/11/23 14:09, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes SPI setup and resolves following validation errors:
> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtb: spi_nand@0: Unevaluated properties are not allowed ('spi-rx-buswidth', 'spi-tx-buswidth' were unexpected)
>          from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
> arch/arm64/boot/dts/mediatek/mt7986b-rfb.dtb: spi_nand@0: Unevaluated properties are not allowed ('spi-rx-buswidth', 'spi-tx-buswidth' were unexpected)
>          from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
> 
> Fixes: 885e153ed7c1 ("arm64: dts: mt7986: add spi related device nodes")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
  2023-11-16 13:09 [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties Rafał Miłecki
  2023-11-16 13:09 ` [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename Rafał Miłecki
  2024-01-03 13:55 ` [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties AngeloGioacchino Del Regno
@ 2024-01-22  9:09 ` Matthias Brugger
  2 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2024-01-22  9:09 UTC (permalink / raw)
  To: Rafał Miłecki, AngeloGioacchino Del Regno, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Sam Shih, Frank Wunderlich, devicetree, linux-arm-kernel,
	linux-mediatek, Rafał Miłecki



On 16/11/2023 14:09, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes SPI setup and resolves following validation errors:
> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dtb: spi_nand@0: Unevaluated properties are not allowed ('spi-rx-buswidth', 'spi-tx-buswidth' were unexpected)
>          from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
> arch/arm64/boot/dts/mediatek/mt7986b-rfb.dtb: spi_nand@0: Unevaluated properties are not allowed ('spi-rx-buswidth', 'spi-tx-buswidth' were unexpected)
>          from schema $id: http://devicetree.org/schemas/mtd/spi-nand.yaml#
> 
> Fixes: 885e153ed7c1 ("arm64: dts: mt7986: add spi related device nodes")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---

Both patches applied now. Thanks!

>   arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 4 ++--
>   arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> index 3ef371ca254e..bcb3ebb85d70 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> @@ -241,8 +241,8 @@ spi_nand: spi_nand@0 {
>   		compatible = "spi-nand";
>   		reg = <0>;
>   		spi-max-frequency = <10000000>;
> -		spi-tx-buswidth = <4>;
> -		spi-rx-buswidth = <4>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
>   	};
>   };
>   
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
> index dde190442e38..48fe50e67177 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts
> @@ -156,8 +156,8 @@ spi_nand: spi_nand@0 {
>   		compatible = "spi-nand";
>   		reg = <0>;
>   		spi-max-frequency = <10000000>;
> -		spi-tx-buswidth = <4>;
> -		spi-rx-buswidth = <4>;
> +		spi-tx-bus-width = <4>;
> +		spi-rx-bus-width = <4>;
>   	};
>   };
>   

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-22  9:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-16 13:09 [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties Rafał Miłecki
2023-11-16 13:09 ` [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename Rafał Miłecki
2024-01-03 13:54   ` AngeloGioacchino Del Regno
2024-01-03 13:55 ` [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties AngeloGioacchino Del Regno
2024-01-22  9:09 ` Matthias Brugger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).