From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F25E9C433FE for ; Sat, 9 Apr 2022 13:18:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241957AbiDINUg (ORCPT ); Sat, 9 Apr 2022 09:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241950AbiDINUe (ORCPT ); Sat, 9 Apr 2022 09:20:34 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FF7F23BC8 for ; Sat, 9 Apr 2022 06:18:26 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id bq8so22248112ejb.10 for ; Sat, 09 Apr 2022 06:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TIvV9HUS6U5uZnee53C8qefZW/ieHFeAYqZWIX5PS5Y=; b=SzRXWvWDjWrGNzjafa7OdZ7o4vH48igNd7Ks1ce5EJ7N6I4dXV5MDU1qtLQ2jzFovL ITZxvtYVCEWld541IVMPomLfM7UzhLXw82SzeUPQnhw4WGEsRDV9ynC/d7wOvDiSXJL1 6jWU5rE5JqUyBNCOGagVZAOxv/7xgYkhbgIhc2wsa+5ndvp2bQHfNZvryIrFBmfygBKi zkwOQ21EPtH3azxG3YsXTBM08W7eBDA/ho0x6AFGZtYQlBQMuR6pbVJOwTW4c/OXpzke X8yuVBwVlsTBhY50urMq1+Js4wjTcDwbXW3/4yv9CApFeW+n0Qmc7RDDK1Eyym7GsGeQ LrZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TIvV9HUS6U5uZnee53C8qefZW/ieHFeAYqZWIX5PS5Y=; b=bCiE3IJvfgSkmIMTWTYm0uplqFdrdw6Iem0Qe9L8ytKnve9r2vK3oJU4dRNnta+6b7 678dtFhU1N4eEOIgVAK3exVuKnmqI3V/2YIHV3Q4sjGRjCHkRzB87AxH/yO8wBb9C4AX ve01OTeEEENboLfQF4JgyLLeat8LdvyG0LbIqxFDYiP5AbO4QL/Q1ugNylSkOvL+HE9T jqWg+ebUlkNaABHhwJvnqwpq2aZlT/ND/TdLJMr8Use+3Im8wqpzkw8yxg5orliX4jXL Tbcz7iM1NTK70dSZ18cFcQ18z95Gr06Bshl9VRkWiyLYucRJ7CDLQMAmtoX8Nl7OWD91 Zg3Q== X-Gm-Message-State: AOAM532Of13G6AWNxUnsVaKWr0oZUuB656d/6+m2Avh5RFAkAXVIdwKG ZMqs9jk30vHXSjpOmLfZQ3iFcw== X-Google-Smtp-Source: ABdhPJyMTC2qnmHi/0NCn+YqVeHeFQKswOIEzO1b2qZlKMPsJ8Q1z+DgYVKcFcBzrX/UfC7asrFiuw== X-Received: by 2002:a17:906:d924:b0:6e8:6a04:c1bc with SMTP id rn4-20020a170906d92400b006e86a04c1bcmr4257899ejb.720.1649510304986; Sat, 09 Apr 2022 06:18:24 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id sh31-20020a1709076e9f00b006e8289e5836sm3550229ejc.117.2022.04.09.06.18.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 06:18:24 -0700 (PDT) Message-ID: <99a97b0f-19a5-136d-9160-c9fde6f3548c@linaro.org> Date: Sat, 9 Apr 2022 15:18:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 13/18] dt-bindings: fix jz4780-nemc issue as reported by dtbscheck Content-Language: en-US To: "H. Nikolaus Schaller" Cc: Rob Herring , Paul Cercueil , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org References: <84adfe6237cd4cfd52cb9723416f69926e556e55.1649443080.git.hns@goldelico.com> <036b66b2-c221-6e9e-6a56-510e7a0d20d3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/04/2022 15:09, H. Nikolaus Schaller wrote: > > >> Am 09.04.2022 um 13:26 schrieb Krzysztof Kozlowski : >> >> On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >>> jz4780-nemc needs to be compatible to simple-mfd as well or we get >>> >>> arch/mips/boot/dts/ingenic/ci20.dtb: memory-controller@13410000: compatible: 'oneOf' conditional failed, one must be fixed: >>> ['ingenic,jz4780-nemc', 'simple-mfd'] is too long >>> 'ingenic,jz4725b-nemc' was expected >>> 'ingenic,jz4740-nemc' was expected >>> From schema: Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >>> >>> Signed-off-by: H. Nikolaus Schaller >>> --- >>> .../devicetree/bindings/memory-controllers/ingenic,nemc.yaml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >>> index 24f9e19820282..3b1116588de3d 100644 >>> --- a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >>> +++ b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >>> @@ -17,7 +17,7 @@ properties: >>> oneOf: >>> - enum: >>> - >>> - - ingenic,jz4780-nemc >>> + - [ , simple-mfd ] >> >> This is not correct representation. If you really need simple-mfd, then >> this should be a separate item below oneOf. > > Well, it is valid YAML syntax and seems to be accepted by dtbscheck. It's not how we code it. Please do not introduce inconsistent - even if valid - blocks. > >> The true question is whether you need simple-mfd. Isn't the binding (and >> the driver) expected to instantiate its children? > > I had expected that but current ingenic,jz4780-nemc code doesn't. Paul provided good reason for the simple-mfd. Use this one instead of dt check warning. DT check warning means nothing, does not bring the actual answer to "why", because it is artificial tool. The answer to "why" is in what Paul wrote. Best regards, Krzysztof