From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A7DC433FE for ; Sun, 3 Apr 2022 15:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240705AbiDCPcG (ORCPT ); Sun, 3 Apr 2022 11:32:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237294AbiDCPcF (ORCPT ); Sun, 3 Apr 2022 11:32:05 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41174393DC for ; Sun, 3 Apr 2022 08:30:10 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id c7so11042300wrd.0 for ; Sun, 03 Apr 2022 08:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=g/pOdUoD+aSLxOxunI/HD3X3dn118+KcjklCC+A61c0=; b=KiRNvDwwTy7V/nXZ51s+7PKUgpf7mFtIMQ1I7yvBHvWorPgiupKGZgboDKlU0bycRG zhCmA9IuNbrJbX5Ziyy0JodN4D6xJeZE1AxUpGEQyRd3sZEZyH0hC0WMIiFkMoNd1dm8 mxR3odG/lCPYWhk4Ncixk/5MXMBub4wCE/jytzG//QrD+ggjRmNUtaLfPQhJXwKmHpCN hgllZLArzcs3h+mseXpNju2E9sMzdo3DxVj3YqZFSREbpQSkhLWXcEakjevm8YmH7Wts vyw7p+Ft4793ob07zsV91d7ja40sQ0LxxnySXcGcy4YdqGeeE4XIsv8vtMKMviw4ik9E 9C5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=g/pOdUoD+aSLxOxunI/HD3X3dn118+KcjklCC+A61c0=; b=BMhDGj5teeOm/BsAhw/g5GCLRGzwNjHF6Bp/8gWA7Az95nr1sqwjGjkSBXf0ghJpVF JZbQ+OeOl68DKmTNS2B1mCyWT1s7lOusIbJxrNz2BFrvNKV0nlCW0ANcyRyhA36PkTHX 9ysjFlHQ+WRyX1BktMvD3bNKqedqZKycxw+Y7vav3hchduObvdB4OIHuAsUZyolHoRbo jmd+kII3xZigfa5tckVxp0EEbTDf3ox83Dq8i1Gmuq87VnVSHr1YIV/PE7s/hHe3L135 V4ki8ZOiUP5gqilpZt5PzEnwj/cJr/emymRcztRw5y2MfAqBOXOa+82KukjQSy+44T1l xiug== X-Gm-Message-State: AOAM531lSzmCWIezXZ5rq2tjZnv9y1H2TtpkKKEoLFMXli0NM9D14f5I FiCZZevZszVFFhFR4E+/4CegDA== X-Google-Smtp-Source: ABdhPJwwB+OVtGxMkpj7zQX5eTLsSBfBcwUVIx+fSag8zqpUp3Pma2boS8iBSUv1j9j0vft+N7t+Lw== X-Received: by 2002:adf:e0ce:0:b0:1ef:706d:d6b9 with SMTP id m14-20020adfe0ce000000b001ef706dd6b9mr14723279wri.71.1648999808830; Sun, 03 Apr 2022 08:30:08 -0700 (PDT) Received: from [192.168.0.172] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id r14-20020a0560001b8e00b00205918bd86esm7025492wru.78.2022.04.03.08.30.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Apr 2022 08:30:08 -0700 (PDT) Message-ID: <99f1181b-fde2-43a5-9b6a-c0c3a8b3933f@linaro.org> Date: Sun, 3 Apr 2022 17:30:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver Content-Language: en-US To: Kuldeep Singh Cc: Caleb Connolly , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Amit Pundir , Sumit Semwal References: <20220401202643.877609-1-caleb.connolly@linaro.org> <20220401202643.877609-7-caleb.connolly@linaro.org> <20220403071426.GA49153@9a2d8922b8f1> <798f0244-95dd-cf2d-7bc5-02c72c7fa327@linaro.org> <20220403133122.GA49428@9a2d8922b8f1> From: Krzysztof Kozlowski In-Reply-To: <20220403133122.GA49428@9a2d8922b8f1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/04/2022 15:31, Kuldeep Singh wrote: > On Sun, Apr 03, 2022 at 09:56:25AM +0200, Krzysztof Kozlowski wrote: >> On 03/04/2022 09:14, Kuldeep Singh wrote: >>> On Fri, Apr 01, 2022 at 09:26:43PM +0100, Caleb Connolly wrote: >>>> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger >>>> drivers. >>>> >> >> (...) >> >>> >>>> + pmic { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + #interrupt-cells = <4>; >>>> + >>>> + smb2@1000 { >>>> + compatible = "qcom,pmi8998-smb2"; >>>> + reg = <0x1000>; >>>> + >>>> + interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>; >>>> + interrupt-names = "usb-plugin"; >>>> + >>> >>> In-between new lines may not be required. >>> And DTs use tabs instead of 2 spaces, we can follow that here also. >> >> The DT examples in bindings use spaces. Either two (like YAML) or four >> (for easier reading). > > ok, since example snippet is taken from DT that's why I said four > spaces(tab) as it will be closest to actual env. You said "use tabs", which is 8 spaces in Linux. So to clarify - we do not use tabs here, so do not use tabs. >>>> + io-channels = <&pmi8998_rradc 3>, >>>> + <&pmi8998_rradc 4>; >>>> + io-channel-names = "usbin_i", >>>> + "usbin_v"; >>> >>> Channel-names can be written in one line. >> >> They match the format of io-channels, so this is quite readable. > > io-channels doesn't exceed max characters in line(i.e 75) even after > being clubbed. Won't be better if kept in one line? > This might be personal perspective but I thought it's worth mentioning. I find current code readable. The other option would be fine as well, kind of does not matter to me much. Best regards, Krzysztof