Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property

[Liu Ying <victor.liu@nxp.com>]

Hi Sam,

On Wed, 2020-11-04 at 11:47 +0100, Sam Ravnborg wrote:
> Hi Liu Ying
> 
> On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote:
> > Some simple panels have dual LVDS interfaces which receive even and
> > odd
> > pixels respectively, like 'nlt,nl192108ac18-02d' and
> > 'koe,tx26d202vm0bwa'.
> > So, let's allow optional 'ports' property so that pixel order can
> > be got
> > via drm_of_lvds_get_dual_link_pixel_order() if it's child nodes 
> > 'port@0'
> > and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-odd-
> > pixels'
> > properties respectively.
> 
> A panel with dual LVDS interfaces is no longer in the "simple"
> category.
> The panel-simple binding shall be limited to the simple pnales only.
> 
> This is also why we have for example panel-simple-dsi binding.
> 
> Please consider either a binding dedicated for the dual port displays
> or

Thanks for your review.

Does a new 'panel-simple-lvds-dual-ports.yaml' binding look ok?
I assume it would inherit all properties of panel-simple.yaml and all
existing compatibles of LVDS panels with dual ports in
panel-simple.yaml can be moved to it.

> a dedicated binding for the specific panel.
> 
> I trust that if other readers of this mail disagrees with this
> recommendation that they will speak up.
> 
> 	Sam
> 
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index f9750b0..5ccb22b 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > @@ -288,6 +288,7 @@ properties:
> >    backlight: true
> >    enable-gpios: true
> >    port: true
> > +  ports: true
> >    power-supply: true
> >  
> >  additionalProperties: false
> > -- 
> > 2.7.4
-- 
 Liu Ying