* [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property
@ 2020-11-04 8:03 Liu Ying
2020-11-04 10:47 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Liu Ying @ 2020-11-04 8:03 UTC (permalink / raw)
To: dri-devel, devicetree
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring
Some simple panels have dual LVDS interfaces which receive even and odd
pixels respectively, like 'nlt,nl192108ac18-02d' and 'koe,tx26d202vm0bwa'.
So, let's allow optional 'ports' property so that pixel order can be got
via drm_of_lvds_get_dual_link_pixel_order() if it's child nodes 'port@0'
and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-odd-pixels'
properties respectively.
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index f9750b0..5ccb22b 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -288,6 +288,7 @@ properties:
backlight: true
enable-gpios: true
port: true
+ ports: true
power-supply: true
additionalProperties: false
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property
2020-11-04 8:03 [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property Liu Ying
@ 2020-11-04 10:47 ` Sam Ravnborg
2020-11-10 2:37 ` Liu Ying
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2020-11-04 10:47 UTC (permalink / raw)
To: Liu Ying
Cc: dri-devel, devicetree, Thierry Reding, David Airlie,
Daniel Vetter, Rob Herring
Hi Liu Ying
On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote:
> Some simple panels have dual LVDS interfaces which receive even and odd
> pixels respectively, like 'nlt,nl192108ac18-02d' and 'koe,tx26d202vm0bwa'.
> So, let's allow optional 'ports' property so that pixel order can be got
> via drm_of_lvds_get_dual_link_pixel_order() if it's child nodes 'port@0'
> and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-odd-pixels'
> properties respectively.
A panel with dual LVDS interfaces is no longer in the "simple" category.
The panel-simple binding shall be limited to the simple pnales only.
This is also why we have for example panel-simple-dsi binding.
Please consider either a binding dedicated for the dual port displays or
a dedicated binding for the specific panel.
I trust that if other readers of this mail disagrees with this
recommendation that they will speak up.
Sam
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index f9750b0..5ccb22b 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -288,6 +288,7 @@ properties:
> backlight: true
> enable-gpios: true
> port: true
> + ports: true
> power-supply: true
>
> additionalProperties: false
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property
2020-11-04 10:47 ` Sam Ravnborg
@ 2020-11-10 2:37 ` Liu Ying
2020-11-10 5:53 ` Sam Ravnborg
0 siblings, 1 reply; 5+ messages in thread
From: Liu Ying @ 2020-11-10 2:37 UTC (permalink / raw)
To: Sam Ravnborg
Cc: dri-devel, devicetree, Thierry Reding, David Airlie,
Daniel Vetter, Rob Herring
Hi Sam,
On Wed, 2020-11-04 at 11:47 +0100, Sam Ravnborg wrote:
> Hi Liu Ying
>
> On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote:
> > Some simple panels have dual LVDS interfaces which receive even and
> > odd
> > pixels respectively, like 'nlt,nl192108ac18-02d' and
> > 'koe,tx26d202vm0bwa'.
> > So, let's allow optional 'ports' property so that pixel order can
> > be got
> > via drm_of_lvds_get_dual_link_pixel_order() if it's child nodes
> > 'port@0'
> > and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-odd-
> > pixels'
> > properties respectively.
>
> A panel with dual LVDS interfaces is no longer in the "simple"
> category.
> The panel-simple binding shall be limited to the simple pnales only.
>
> This is also why we have for example panel-simple-dsi binding.
>
> Please consider either a binding dedicated for the dual port displays
> or
Thanks for your review.
Does a new 'panel-simple-lvds-dual-ports.yaml' binding look ok?
I assume it would inherit all properties of panel-simple.yaml and all
existing compatibles of LVDS panels with dual ports in
panel-simple.yaml can be moved to it.
> a dedicated binding for the specific panel.
>
> I trust that if other readers of this mail disagrees with this
> recommendation that they will speak up.
>
> Sam
>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index f9750b0..5ccb22b 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-
> > simple.yaml
> > @@ -288,6 +288,7 @@ properties:
> > backlight: true
> > enable-gpios: true
> > port: true
> > + ports: true
> > power-supply: true
> >
> > additionalProperties: false
> > --
> > 2.7.4
--
Liu Ying
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property
2020-11-10 2:37 ` Liu Ying
@ 2020-11-10 5:53 ` Sam Ravnborg
2020-11-10 9:17 ` Liu Ying
0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2020-11-10 5:53 UTC (permalink / raw)
To: Liu Ying
Cc: dri-devel, devicetree, Thierry Reding, David Airlie,
Daniel Vetter, Rob Herring
Hi Liu Ying,
On Tue, Nov 10, 2020 at 10:37:27AM +0800, Liu Ying wrote:
> Hi Sam,
>
> On Wed, 2020-11-04 at 11:47 +0100, Sam Ravnborg wrote:
> > Hi Liu Ying
> >
> > On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote:
> > > Some simple panels have dual LVDS interfaces which receive even and
> > > odd
> > > pixels respectively, like 'nlt,nl192108ac18-02d' and
> > > 'koe,tx26d202vm0bwa'.
> > > So, let's allow optional 'ports' property so that pixel order can
> > > be got
> > > via drm_of_lvds_get_dual_link_pixel_order() if it's child nodes
> > > 'port@0'
> > > and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-odd-
> > > pixels'
> > > properties respectively.
> >
> > A panel with dual LVDS interfaces is no longer in the "simple"
> > category.
> > The panel-simple binding shall be limited to the simple pnales only.
> >
> > This is also why we have for example panel-simple-dsi binding.
> >
> > Please consider either a binding dedicated for the dual port displays
> > or
>
> Thanks for your review.
>
> Does a new 'panel-simple-lvds-dual-ports.yaml' binding look ok?
> I assume it would inherit all properties of panel-simple.yaml and all
> existing compatibles of LVDS panels with dual ports in
> panel-simple.yaml can be moved to it.
Yes, that would be fine. If possible we shall have similar panels
described by the same binding.
Try to send out the binding for review early before starting to move too
much around - so we can get an early look at it at see if this is indeed
the right direction to go.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property
2020-11-10 5:53 ` Sam Ravnborg
@ 2020-11-10 9:17 ` Liu Ying
0 siblings, 0 replies; 5+ messages in thread
From: Liu Ying @ 2020-11-10 9:17 UTC (permalink / raw)
To: Sam Ravnborg
Cc: devicetree, David Airlie, dri-devel, Rob Herring, Thierry Reding
On Tue, 2020-11-10 at 06:53 +0100, Sam Ravnborg wrote:
> Hi Liu Ying,
> On Tue, Nov 10, 2020 at 10:37:27AM +0800, Liu Ying wrote:
> > Hi Sam,
> >
> > On Wed, 2020-11-04 at 11:47 +0100, Sam Ravnborg wrote:
> > > Hi Liu Ying
> > >
> > > On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote:
> > > > Some simple panels have dual LVDS interfaces which receive even
> > > > and
> > > > odd
> > > > pixels respectively, like 'nlt,nl192108ac18-02d' and
> > > > 'koe,tx26d202vm0bwa'.
> > > > So, let's allow optional 'ports' property so that pixel order
> > > > can
> > > > be got
> > > > via drm_of_lvds_get_dual_link_pixel_order() if it's child
> > > > nodes
> > > > 'port@0'
> > > > and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-
> > > > odd-
> > > > pixels'
> > > > properties respectively.
> > >
> > > A panel with dual LVDS interfaces is no longer in the "simple"
> > > category.
> > > The panel-simple binding shall be limited to the simple pnales
> > > only.
> > >
> > > This is also why we have for example panel-simple-dsi binding.
> > >
> > > Please consider either a binding dedicated for the dual port
> > > displays
> > > or
> >
> > Thanks for your review.
> >
> > Does a new 'panel-simple-lvds-dual-ports.yaml' binding look ok?
> > I assume it would inherit all properties of panel-simple.yaml and
> > all
> > existing compatibles of LVDS panels with dual ports in
> > panel-simple.yaml can be moved to it.
>
> Yes, that would be fine. If possible we shall have similar panels
> described by the same binding.
>
> Try to send out the binding for review early before starting to move
> too
> much around - so we can get an early look at it at see if this is
> indeed
> the right direction to go.
Yes. I've sent out one for review:
https://lists.freedesktop.org/archives/dri-devel/2020-November/286482.html
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Liu Ying
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-10 9:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-04 8:03 [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property Liu Ying
2020-11-04 10:47 ` Sam Ravnborg
2020-11-10 2:37 ` Liu Ying
2020-11-10 5:53 ` Sam Ravnborg
2020-11-10 9:17 ` Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).