Re: [PATCH v1 1/3] MIPS: dts: ralink: mt7628a: Fix sysc's compatible property for MT7688

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/06/2025 13:50, Ezra Buehler wrote:
>>> diff --git a/arch/mips/boot/dts/ralink/mt7628a.dtsi b/arch/mips/boot/dts/ralink/mt7628a.dtsi
>>> index 0212700c4fb4..10221a41f02a 100644
>>> --- a/arch/mips/boot/dts/ralink/mt7628a.dtsi
>>> +++ b/arch/mips/boot/dts/ralink/mt7628a.dtsi
>>> @@ -33,7 +33,7 @@ palmbus@10000000 {
>>>               #size-cells = <1>;
>>>
>>>               sysc: syscon@0 {
>>> -                     compatible = "ralink,mt7628-sysc", "syscon";
>>> +                     compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>> This is in contradiction to bindings, so you need to fix bindings first
>> - with proper justification. If this happened in separate patchset, then
>> the DTS thread MUST provide lore link to that.
> 
> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
> used for both SoCs. Therefore, I'd rather suggest adapting the driver to
> return "ralink,mt7628-sysc" in both cases and remove "ralink,mt7688-sysc"
> from the DT bindings.


Not sure what you propose here, but just in case: devices need specific
compatibles.

> 
> I'd love to hear Sergio's (or any other) opinion on this matter.
> 
> Cheers,
> Ezra


Best regards,
Krzysztof