From: <Codrin.Ciubotariu@microchip.com>
To: <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <Nicolas.Ferre@microchip.com>,
<Claudiu.Beznea@microchip.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <f.fainelli@gmail.com>, <robh+dt@kernel.org>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node
Date: Tue, 21 Jul 2020 13:40:17 +0000 [thread overview]
Message-ID: <9a30d357-7fc0-13d3-bba3-c4d29c36cfc2@microchip.com> (raw)
In-Reply-To: <20200721133655.GA1472201@lunn.ch>
On 21.07.2020 16:36, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>> * decrement it before returning.
>> */
>> of_node_put(child);
>> -
>> return of_mdiobus_register(bp->mii_bus, np);
>> }
>
> Please avoid white space changes like this.
Sorry about this, it was not intended. Will fix in v2. Thanks!
>
> Otherwise this looks O.K.
>
> Andrew
>
next prev parent reply other threads:[~2020-07-21 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 10:02 [PATCH net-next 0/7] Add an MDIO sub-node under MACB Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 1/7] net: macb: use device-managed devm_mdiobus_alloc() Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 2/7] macb: bindings doc: use an MDIO node as a container for PHY nodes Codrin Ciubotariu
2020-07-21 13:29 ` Alexandre Belloni
2020-07-21 13:44 ` Codrin.Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node Codrin Ciubotariu
2020-07-21 13:36 ` Andrew Lunn
2020-07-21 13:40 ` Codrin.Ciubotariu [this message]
2020-07-21 13:42 ` Codrin.Ciubotariu
2020-07-21 13:44 ` Codrin.Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 4/7] ARM: dts: at91: sama5d2: add an mdio sub-node to macb Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 5/7] ARM: dts: at91: sama5d3: " Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 6/7] ARM: dts: at91: sama5d4: " Codrin Ciubotariu
2020-07-21 10:02 ` [PATCH net-next 7/7] ARM: dts: at91: sam9x60: " Codrin Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a30d357-7fc0-13d3-bba3-c4d29c36cfc2@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).