From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saurabh Sengar <ssengar@linux.microsoft.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, daniel.lezcano@linaro.org,
tglx@linutronix.de, virtualization@lists.linux-foundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, mikelley@microsoft.com,
ssengar@microsoft.com
Subject: Re: [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus
Date: Tue, 31 Jan 2023 19:54:56 +0100 [thread overview]
Message-ID: <9a3bbaf0-eb1d-613a-a8ba-272896ef2da8@linaro.org> (raw)
In-Reply-To: <1675188609-20913-6-git-send-email-ssengar@linux.microsoft.com>
On 31/01/2023 19:10, Saurabh Sengar wrote:
>
> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> + - |
> + / {
> + compatible = "foo";
> + model = "foo";
> + #address-cells = <0x02>;
> + #size-cells = <0x02>;
Except previous comments (all of them were ignored), also:
Drop entire part. Not related, not correct, not helping and you cannot
have top level nodes in example.
> +
> + vmbus@ff0000000 {
> + #address-cells = <0x02>;
> + #size-cells = <0x01>;
> + compatible = "msft,vmbus";
> + ranges = <0x00 0x00 0x0f 0xf0000000 0x10000000>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 1f7a519a936f..ab74ea97535f 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -876,6 +876,8 @@ patternProperties:
> deprecated: true
> "^mscc,.*":
> description: Microsemi Corporation
> + "^msft,.*":
> + description: Microsoft Corporation
Don't duplicate vendor prefixes. Drop and use correct prefix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-31 18:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 18:10 [PATCH v2 0/6] Device tree support for Hyper-V VMBus driver Saurabh Sengar
2023-01-31 18:10 ` [PATCH v2 1/6] drivers/clocksource/hyper-v: non ACPI support in hyperv clock Saurabh Sengar
2023-01-31 18:10 ` [PATCH v2 2/6] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Saurabh Sengar
2023-02-01 17:47 ` Michael Kelley (LINUX)
2023-02-02 14:48 ` Saurabh Singh Sengar
2023-02-02 15:33 ` Michael Kelley (LINUX)
2023-01-31 18:10 ` [PATCH v2 3/6] Drivers: hv: vmbus: Convert acpi_device to platform_device Saurabh Sengar
2023-02-01 18:32 ` Michael Kelley (LINUX)
2023-02-02 15:27 ` Saurabh Singh Sengar
2023-02-03 5:32 ` Saurabh Singh Sengar
2023-01-31 18:10 ` [PATCH v2 4/6] dt-bindings: hypervisor: Rename virtio to hypervisor Saurabh Sengar
2023-01-31 19:57 ` Rob Herring
2023-02-01 5:36 ` Saurabh Singh Sengar
2023-01-31 18:10 ` [PATCH v2 5/6] dt-bindings: hypervisor: Add dt-bindings for VMBus Saurabh Sengar
2023-01-31 18:51 ` Krzysztof Kozlowski
2023-02-01 1:39 ` Saurabh Singh Sengar
2023-01-31 18:54 ` Krzysztof Kozlowski [this message]
2023-02-01 1:57 ` Saurabh Singh Sengar
2023-02-01 7:23 ` Krzysztof Kozlowski
2023-02-01 8:05 ` Saurabh Singh Sengar
2023-01-31 18:10 ` [PATCH v2 6/6] Driver: VMBus: Add device tree support Saurabh Sengar
2023-01-31 20:12 ` Rob Herring
2023-02-01 16:51 ` Saurabh Singh Sengar
2023-02-01 17:46 ` Rob Herring
2023-02-01 18:31 ` Saurabh Singh Sengar
2023-02-03 17:36 ` Saurabh Singh Sengar
2023-02-07 17:38 ` Rob Herring
2023-02-08 2:30 ` Saurabh Singh Sengar
2023-01-31 20:27 ` [PATCH v2 0/6] Device tree support for Hyper-V VMBus driver Rob Herring
2023-02-01 2:04 ` Saurabh Singh Sengar
2023-02-01 14:51 ` Rob Herring
2023-02-01 16:34 ` Saurabh Singh Sengar
2023-02-01 17:15 ` Krzysztof Kozlowski
2023-02-06 17:40 ` Saurabh Singh Sengar
2023-02-07 17:53 ` Rob Herring
2023-02-08 2:44 ` Saurabh Singh Sengar
2023-02-07 18:37 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a3bbaf0-eb1d-613a-a8ba-272896ef2da8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=robh+dt@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).