From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: add cpufreq node
Date: Tue, 21 Feb 2023 18:44:55 +0100 [thread overview]
Message-ID: <9a3e9c76-ba70-6ccc-3ade-fa08cdff571e@linaro.org> (raw)
In-Reply-To: <20230221150543.283487-3-brgl@bgdev.pl>
On 21.02.2023 16:05, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Add a node for the cpufreq engine and specify the frequency domains for
> all CPUs.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index ce5976e36aee..5e2bc67b3178 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -37,6 +37,7 @@ CPU0: cpu@0 {
> compatible = "qcom,kryo";
> reg = <0x0 0x0>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 0>;
> next-level-cache = <&L2_0>;
> L2_0: l2-cache {
> compatible = "cache";
> @@ -52,6 +53,7 @@ CPU1: cpu@100 {
> compatible = "qcom,kryo";
> reg = <0x0 0x100>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 0>;
> next-level-cache = <&L2_1>;
> L2_1: l2-cache {
> compatible = "cache";
> @@ -64,6 +66,7 @@ CPU2: cpu@200 {
> compatible = "qcom,kryo";
> reg = <0x0 0x200>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 0>;
> next-level-cache = <&L2_2>;
> L2_2: l2-cache {
> compatible = "cache";
> @@ -76,6 +79,7 @@ CPU3: cpu@300 {
> compatible = "qcom,kryo";
> reg = <0x0 0x300>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 0>;
> next-level-cache = <&L2_3>;
> L2_3: l2-cache {
> compatible = "cache";
> @@ -88,6 +92,7 @@ CPU4: cpu@10000 {
> compatible = "qcom,kryo";
> reg = <0x0 0x10000>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 1>;
> next-level-cache = <&L2_4>;
> L2_4: l2-cache {
> compatible = "cache";
> @@ -104,6 +109,7 @@ CPU5: cpu@10100 {
> compatible = "qcom,kryo";
> reg = <0x0 0x10100>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 1>;
> next-level-cache = <&L2_5>;
> L2_5: l2-cache {
> compatible = "cache";
> @@ -116,6 +122,7 @@ CPU6: cpu@10200 {
> compatible = "qcom,kryo";
> reg = <0x0 0x10200>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 1>;
> next-level-cache = <&L2_6>;
> L2_6: l2-cache {
> compatible = "cache";
> @@ -128,6 +135,7 @@ CPU7: cpu@10300 {
> compatible = "qcom,kryo";
> reg = <0x0 0x10300>;
> enable-method = "psci";
> + qcom,freq-domain = <&cpufreq_hw 1>;
> next-level-cache = <&L2_7>;
> L2_7: l2-cache {
> compatible = "cache";
> @@ -731,6 +739,19 @@ tcsr_mutex: hwlock@1f40000 {
> #hwlock-cells = <1>;
> };
>
> + cpufreq_hw: cpufreq@18591000 {
> + compatible = "qcom,sa8775p-cpufreq-epss",
> + "qcom,cpufreq-epss";
That's some very aggressive wrapping! :P
Nevertheless,
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> + reg = <0x0 0x18591000 0x0 0x1000>,
> + <0x0 0x18593000 0x0 0x1000>;
> + reg-names = "freq-domain0", "freq-domain1";
> +
> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
> + clock-names = "xo", "alternate";
> +
> + #freq-domain-cells = <1>;
> + };
> +
> tlmm: pinctrl@f000000 {
> compatible = "qcom,sa8775p-tlmm";
> reg = <0x0 0xf000000 0x0 0x1000000>;
next prev parent reply other threads:[~2023-02-21 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 15:05 [PATCH 0/2] arm64: qcom: sa8775p: enable cpufreq Bartosz Golaszewski
2023-02-21 15:05 ` [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a compatible for sa8775p Bartosz Golaszewski
2023-02-21 15:46 ` Krzysztof Kozlowski
2023-02-23 4:18 ` Viresh Kumar
2023-02-21 15:05 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: add cpufreq node Bartosz Golaszewski
2023-02-21 17:44 ` Konrad Dybcio [this message]
2023-02-21 19:25 ` Bartosz Golaszewski
2023-03-06 13:34 ` Bartosz Golaszewski
2023-03-15 23:34 ` (subset) [PATCH 0/2] arm64: qcom: sa8775p: enable cpufreq Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a3e9c76-ba70-6ccc-3ade-fa08cdff571e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).