From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Haylen Chu <heylenay@4d2.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Haylen Chu <heylenay@outlook.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Inochi Amaoto <inochiama@outlook.com>,
Chen Wang <unicornxdotw@foxmail.com>,
Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH v3 3/3] clk: spacemit: Add clock support for Spacemit K1 SoC
Date: Mon, 9 Dec 2024 09:51:48 +0300 [thread overview]
Message-ID: <9a3f6975-d99d-430b-9a09-697638667e97@stanley.mountain> (raw)
In-Reply-To: <20241126143125.9980-7-heylenay@4d2.org>
Hi Haylen,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Haylen-Chu/dt-bindings-clock-spacemit-Add-clock-controllers-of-Spacemit-K1-SoC/20241128-101248
base: 2d5404caa8c7bb5c4e0435f94b28834ae5456623
patch link: https://lore.kernel.org/r/20241126143125.9980-7-heylenay%404d2.org
patch subject: [PATCH v3 3/3] clk: spacemit: Add clock support for Spacemit K1 SoC
config: arm64-randconfig-r073-20241207 (https://download.01.org/0day-ci/archive/20241207/202412072123.ne7GnRyJ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202412072123.ne7GnRyJ-lkp@intel.com/
smatch warnings:
drivers/clk/spacemit/ccu-k1.c:1686 k1_ccu_probe() error: uninitialized symbol 'lock_map'.
vim +/lock_map +1686 drivers/clk/spacemit/ccu-k1.c
e71e4621b06cd42 Haylen Chu 2024-11-26 1651 static int k1_ccu_probe(struct platform_device *pdev)
e71e4621b06cd42 Haylen Chu 2024-11-26 1652 {
e71e4621b06cd42 Haylen Chu 2024-11-26 1653 const struct spacemit_ccu_data *data;
e71e4621b06cd42 Haylen Chu 2024-11-26 1654 struct regmap *base_map, *lock_map;
e71e4621b06cd42 Haylen Chu 2024-11-26 1655 struct device *dev = &pdev->dev;
e71e4621b06cd42 Haylen Chu 2024-11-26 1656 struct spacemit_ccu_priv *priv;
e71e4621b06cd42 Haylen Chu 2024-11-26 1657 struct device_node *parent;
e71e4621b06cd42 Haylen Chu 2024-11-26 1658 int ret;
e71e4621b06cd42 Haylen Chu 2024-11-26 1659
e71e4621b06cd42 Haylen Chu 2024-11-26 1660 data = of_device_get_match_data(dev);
e71e4621b06cd42 Haylen Chu 2024-11-26 1661 if (WARN_ON(!data))
e71e4621b06cd42 Haylen Chu 2024-11-26 1662 return -EINVAL;
e71e4621b06cd42 Haylen Chu 2024-11-26 1663
e71e4621b06cd42 Haylen Chu 2024-11-26 1664 parent = of_get_parent(dev->of_node);
e71e4621b06cd42 Haylen Chu 2024-11-26 1665 base_map = syscon_node_to_regmap(parent);
e71e4621b06cd42 Haylen Chu 2024-11-26 1666 of_node_put(parent);
e71e4621b06cd42 Haylen Chu 2024-11-26 1667
e71e4621b06cd42 Haylen Chu 2024-11-26 1668 if (IS_ERR(base_map))
e71e4621b06cd42 Haylen Chu 2024-11-26 1669 return dev_err_probe(dev, PTR_ERR(base_map),
e71e4621b06cd42 Haylen Chu 2024-11-26 1670 "failed to get regmap\n");
e71e4621b06cd42 Haylen Chu 2024-11-26 1671
e71e4621b06cd42 Haylen Chu 2024-11-26 1672 if (data->need_pll_lock) {
e71e4621b06cd42 Haylen Chu 2024-11-26 1673 lock_map = syscon_regmap_lookup_by_phandle(dev->of_node,
e71e4621b06cd42 Haylen Chu 2024-11-26 1674 "spacemit,mpmu");
e71e4621b06cd42 Haylen Chu 2024-11-26 1675 if (IS_ERR(lock_map))
e71e4621b06cd42 Haylen Chu 2024-11-26 1676 return dev_err_probe(dev, PTR_ERR(lock_map),
e71e4621b06cd42 Haylen Chu 2024-11-26 1677 "failed to get lock regmap\n");
e71e4621b06cd42 Haylen Chu 2024-11-26 1678 }
lock_map not initialized on else path.
e71e4621b06cd42 Haylen Chu 2024-11-26 1679
e71e4621b06cd42 Haylen Chu 2024-11-26 1680 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
e71e4621b06cd42 Haylen Chu 2024-11-26 1681 if (!priv)
e71e4621b06cd42 Haylen Chu 2024-11-26 1682 return -ENOMEM;
e71e4621b06cd42 Haylen Chu 2024-11-26 1683
e71e4621b06cd42 Haylen Chu 2024-11-26 1684 priv->data = data;
e71e4621b06cd42 Haylen Chu 2024-11-26 1685 priv->base = base_map;
e71e4621b06cd42 Haylen Chu 2024-11-26 @1686 priv->lock_base = lock_map;
^^^^^^^^^
e71e4621b06cd42 Haylen Chu 2024-11-26 1687
e71e4621b06cd42 Haylen Chu 2024-11-26 1688 ret = spacemit_ccu_register(dev, priv);
e71e4621b06cd42 Haylen Chu 2024-11-26 1689 if (ret)
e71e4621b06cd42 Haylen Chu 2024-11-26 1690 return dev_err_probe(dev, ret, "failed to register clocks\n");
e71e4621b06cd42 Haylen Chu 2024-11-26 1691
e71e4621b06cd42 Haylen Chu 2024-11-26 1692 return 0;
e71e4621b06cd42 Haylen Chu 2024-11-26 1693 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-12-09 6:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 14:31 [PATCH v3 0/3] Add clock controller support for Spacemit K1 Haylen Chu
2024-11-26 14:31 ` [PATCH v3 1/3] dt-bindings: clock: spacemit: Add clock controllers of Spacemit K1 SoC Haylen Chu
2024-11-26 14:48 ` Krzysztof Kozlowski
2024-11-27 8:03 ` Krzysztof Kozlowski
2024-11-27 10:37 ` Haylen Chu
2024-11-26 14:31 ` [PATCH v3 2/3] dt-bindings: soc: spacemit: Add spacemit,k1-syscon Haylen Chu
2024-11-26 14:46 ` Krzysztof Kozlowski
2024-11-26 14:50 ` Krzysztof Kozlowski
2024-11-27 11:01 ` Haylen Chu
2024-11-26 14:31 ` [PATCH v3 3/3] clk: spacemit: Add clock support for Spacemit K1 SoC Haylen Chu
2024-11-28 6:50 ` kernel test robot
2024-11-28 16:07 ` kernel test robot
2024-11-29 15:31 ` kernel test robot
2024-12-08 6:47 ` Inochi Amaoto
2024-12-18 7:27 ` Yixun Lan
2024-12-18 9:03 ` Inochi Amaoto
2024-12-18 12:36 ` Haylen Chu
2024-12-09 6:51 ` Dan Carpenter [this message]
2024-11-26 14:44 ` [PATCH v3 0/3] Add clock controller support for Spacemit K1 Krzysztof Kozlowski
2024-11-27 10:55 ` Haylen Chu
2024-12-04 11:54 ` Emil Renner Berthing
2024-12-18 7:31 ` Yixun Lan
2024-12-18 10:46 ` Haylen Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a3f6975-d99d-430b-9a09-697638667e97@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heylenay@4d2.org \
--cc=heylenay@outlook.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=unicornxdotw@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox