From: Jon Hunter <jonathanh@nvidia.com>
To: Niklas Cassel <cassel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Vidya Sagar <vidyas@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Gautham Srinivasan <gauthams@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] arm64: tegra: Add pinctrl definition for PCIe C4 EP
Date: Tue, 30 Sep 2025 16:13:15 +0100 [thread overview]
Message-ID: <9a4e45df-785b-4620-b86b-92f9121d9dbd@nvidia.com> (raw)
In-Reply-To: <aNVlhjAcCnGI0ziT@ryzen>
On 25/09/2025 16:53, Niklas Cassel wrote:
> On Fri, Sep 19, 2025 at 02:09:21PM +0200, Niklas Cassel wrote:
>> From: Gautham Srinivasan <gauthams@nvidia.com>
>>
>> Commit 0580286d0d22 ("arm64: tegra: Add Tegra234 PCIe C4 EP definition")
>> added the device tree entry "pcie-ep@14160000" for C4 endpoint. However,
>> it missed pinctrl definition. Without the pinctl definition, the C4
>> endpoint of Jetson Orin Nano does not work. Add the missing definition.
>>
>> Signed-off-by: Gautham Srinivasan <gauthams@nvidia.com>
>> [cassel: Add to the existing nodes instead of creating new ones.
>> Remove non-existing nvidia,lpdr property. Rename node to match dtschema.]
>> Signed-off-by: Niklas Cassel <cassel@kernel.org>
>> ---
>> Changes since v1:
>> -Remove non-existing nvidia,lpdr pinmux property.
>> -Rename pex_rst_c4_in to pinmux-pex-rst-c4-in to match dtschema requirement.
>>
>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>
> Hello Tegra architecture maintainers,
>
> any chance that this could get queued up for 6.18-rc1 ?
>
> The device tree node it modifies pcie-ep@14160000 is marked as disabled
> by default, so there should be no risk of regressions.
Sorry looks like this missed v6.18-rc1. However, looking at this some
more, I believe that this is applicable to all Tegra234 platforms. In
fact, I see that we are also missing the pinmux for the other EP devices
too [0]. It might make sense to add these all at once to the tegra234.dtsi.
Jon
[0]
https://nv-tegra.nvidia.com/r/plugins/gitiles/device/hardware/nvidia/t23x-public-dts/+/refs/heads/rel-36/nv-soc/tegra234-soc-overlay.dtsi
--
nvpublic
prev parent reply other threads:[~2025-09-30 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 12:09 [PATCH v2] arm64: tegra: Add pinctrl definition for PCIe C4 EP Niklas Cassel
2025-09-25 15:53 ` Niklas Cassel
2025-09-30 15:13 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4e45df-785b-4620-b86b-92f9121d9dbd@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gauthams@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox