From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Geis Subject: Re: [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac Date: Mon, 22 Apr 2019 07:57:56 -0400 Message-ID: <9a5c62b4-ea75-de4f-9b71-ffa42cb8eaac@gmail.com> References: <20190417210059.26262-1-papadakospan@gmail.com> <8865b046-fb3a-4071-335c-66abb344d7f4@gmail.com> <1555915435.1262.1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1555915435.1262.1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: "Leonidas P. Papadakos" Cc: Jose Abreu , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Robin Murphy , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Yes, I ensured force_thresh_dma_mode was disabled. I submitted the force_thresh_dma_mode patch so that we could at least get functional tx. I'll mess about with tweaking that value to see if I can get anything better. On 4/22/2019 2:43 AM, Leonidas P. Papadakos wrote: > > Indeed that feature would be optimal. Just to confirm, you have replaced > force_thresh_dma_mode with this txpbl thing, right? > That is the only ethernet modification I have in the dts, done though > u-boot. That is on linux 5.1 > >> fdt rm /ethernet@ff540000 snps,force_thresh_dma_mode >> fdt set /ethernet@ff540000 snps,txpbl <0x4> > >