From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, saikrishna12468@gmail.com,
git@amd.com
Subject: Re: [PATCH 1/2] dt-bindings: mtd: spi-nor: Add reset-gpios property
Date: Tue, 30 Aug 2022 12:21:41 +0300 [thread overview]
Message-ID: <9a63271b-48c0-1b31-c450-5abc9eedbced@linaro.org> (raw)
In-Reply-To: <20220829090528.21613-2-sai.krishna.potthuri@amd.com>
On 29/08/2022 12:05, Sai Krishna Potthuri wrote:
> SPI-NOR flashes have RESET pin which can be toggled using GPIO
> controller, for those platforms reset-gpios property can be used to
> reset the flash device.
>
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 7149784a36ac..d2fc8e9c787f 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -70,6 +70,12 @@ properties:
> be used on such systems, to denote the absence of a reliable reset
> mechanism.
>
> + reset-gpios:
> + description:
> + contains a GPIO specifier.
Skip this part - obvious.
> The reset GPIO is asserted and then deasserted
> + to perform device reset. If "broken-flash-reset" is present then having
> + this property does not make any difference.
Isn't then broken-flash-reset conflicting with this one (e.g.
disallowing it)?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-30 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 9:05 [PATCH 0/2] mtd: spi-nor: Add flash device reset support Sai Krishna Potthuri
2022-08-29 9:05 ` [PATCH 1/2] dt-bindings: mtd: spi-nor: Add reset-gpios property Sai Krishna Potthuri
2022-08-30 9:21 ` Krzysztof Kozlowski [this message]
2022-08-30 9:36 ` Michael Walle
2022-08-30 9:48 ` Krzysztof Kozlowski
2022-08-29 9:05 ` [PATCH 2/2] mtd: spi-nor: Add support for flash reset Sai Krishna Potthuri
2022-08-29 10:04 ` Michael Walle
2022-08-30 6:32 ` Potthuri, Sai Krishna
2022-08-30 7:09 ` Michael Walle
2022-08-30 10:22 ` Potthuri, Sai Krishna
2022-09-01 1:57 ` Takahiro Kuwano
2022-09-01 5:15 ` Potthuri, Sai Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a63271b-48c0-1b31-c450-5abc9eedbced@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=saikrishna12468@gmail.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).