From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 06/26] PCI: keystone: Move initializations to appropriate places Date: Mon, 15 Apr 2019 11:04:10 +0530 Message-ID: <9ab596e8-b012-7f4e-aa93-c5661827af95@ti.com> References: <20190325083501.8088-1-kishon@ti.com> <20190325083501.8088-7-kishon@ti.com> <20190413143001.GE126710@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190413143001.GE126710@google.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Bjorn Helgaas Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Murali Karicheri , linux-arm-kernel@axis.com, Jingoo Han , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgQmpvcm4sCgpPbiAxMy8wNC8xOSA4OjAwIFBNLCBCam9ybiBIZWxnYWFzIHdyb3RlOgo+IE9u IE1vbiwgTWFyIDI1LCAyMDE5IGF0IDAyOjA0OjQxUE0gKzA1MzAsIEtpc2hvbiBWaWpheSBBYnJh aGFtIEkgd3JvdGU6Cj4+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLiBNb3ZlIGhvc3Qgc3BlY2lmaWMg cGxhdGZvcm1fZ2V0X3Jlc291cmNlIHRvCj4+IGtzX2FkZF9wY2llX3BvcnQgYW5kIHRoZSBjb21t b24gcGxhdGZvcm1fZ2V0X3Jlc291cmNlIChhcHBsaWNhYmxlCj4+IHRvIGJvdGggaG9zdCBhbmQg ZW5kcG9pbnQpIHRvIHByb2JlLiBUaGlzIGlzIGluIHByZXBhcmF0aW9uIGZvcgo+PiBhZGRpbmcg ZW5kcG9pbnQgc3VwcG9ydCB0byBwY2kta2V5c3RvbmUgZHJpdmVyLgo+IAo+IFRoaXMgc2VlbXMg dG8gbW92ZSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UoKSAqZnJvbSogKG5vdCAqdG8qKQo+IGtzX2Fk ZF9wY2llX3BvcnQoKS4KCk1heWJlIEkgc2hvdWxkIGhhdmUgbWVudGlvbmVkICJLZWVwIGhvc3Qg c3BlY2lmaWMgcGxhdGZvcm1fZ2V0X3Jlc291cmNlKCkgaW4Ka3NfYWRkX3BjaWVfcG9ydCgpIGFu ZCBtb3ZlIHRoZSBjb21tb24gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKCkgKGFwcGxpY2FibGUKdG8g Ym90aCBob3N0IGFuZCBlbmRwb2ludCkgdG8gcHJvYmUoKSIKPiAKPiBZb3Ugc2VlbSB0byBiZSBt YWtpbmcgYSBkaXN0aW5jdGlvbiBpbiB0aGUgY29tbWl0IGxvZyBiZXR3ZWVuICgxKSBhCj4gcmVz b3VyY2UgdGhhdCdzIG9ubHkgdXNlZCBmb3IgaG9zdCBtb2RlLCBhbmQgKDIpIGEgY29tbW9uIHJl c291cmNlCj4gdGhhdCdzIHVzZWQgZm9yIGJvdGggaG9zdCBhbmQgZW5kcG9pbnQgbW9kZS7CoCBC dXQgSSBkb24ndCBzZWUgdGhhdAo+IGRpc3RpbmN0aW9uIGluIHRoZSBwYXRjaCwgc28gaXQncyBh IGxpdHRsZSBjb25mdXNpbmcgdG8gbWVudGlvbiBpdCBpbgo+IHRoZSBjb21taXQgbG9nLgo+IAo+ IEl0IG11c3QgbWFrZSBlbmRwb2ludCBzdXBwb3J0IGVhc2llciwgYnV0IEkgY2FuJ3QgcXVpdGUg Y29ubmVjdCB0aGUKPiBkb3RzIHlldC4gIE1heWJlIGVuZHBvaW50IHdpbGwgYWxzbyB1c2Uga3Nf cGNpZV9hZGRfcGNpZV9wb3J0KCksIGJ1dAo+IHdpbGwgaGF2ZSBhIHNlcGFyYXRlIC5wcm9iZSgp IGZ1bmN0aW9uIHRoYXQgZG9lc24ndCBsb29rIHVwIHRoZQo+IHJlc291cmNlIHRoYXQncyBzcGVj aWZpYyB0byBob3N0IG1vZGU/CgpObyBrc19wY2llX2FkZF9wY2llX3BvcnQoKSBpcyBzcGVjaWZp YyB0byBob3N0IG1vZGUsIHNvICJjb25maWciIHJlc291cmNlIGlzCmtlcHQgdGhlcmUgd2hlcmVh cyAiZGJpY3MiIGFuZCAiYXBwIiByZXNvdXJjZXMgYXJlIGNvbW1vbiB0byBib3RoIGhvc3QgbW9k ZSBhbmQKZGV2aWNlIG1vZGUsIHNvIHRoZXkgYXJlIG1vdmVkIHRvIHByb2JlKCkuCgpUaGFua3MK S2lzaG9uCgo+IAo+PiBTaWduZWQtb2ZmLWJ5OiBLaXNob24gVmlqYXkgQWJyYWhhbSBJIDxraXNo b25AdGkuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlz dG9uZS5jIHwgMjcgKysrKysrKysrKysrKy0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAx NSBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jIGIvZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWtleXN0b25lLmMKPj4gaW5kZXggNWVlYmVmOWI5YWRhLi45NTk5Nzg4NWEw NWMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9u ZS5jCj4+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1rZXlzdG9uZS5jCj4+ IEBAIC04MDYsMTEgKzgwNiw2IEBAIHN0YXRpYyBpbnQgX19pbml0IGtzX3BjaWVfYWRkX3BjaWVf cG9ydChzdHJ1Y3Qga2V5c3RvbmVfcGNpZSAqa3NfcGNpZSwKPj4gIAlzdHJ1Y3QgcmVzb3VyY2Ug KnJlczsKPj4gIAlpbnQgcmV0Owo+PiAgCj4+IC0JcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNl X2J5bmFtZShwZGV2LCBJT1JFU09VUkNFX01FTSwgImRiaWNzIik7Cj4+IC0JcGNpLT5kYmlfYmFz ZSA9IGRldm1fcGNpX3JlbWFwX2NmZ19yZXNvdXJjZShkZXYsIHJlcyk7Cj4+IC0JaWYgKElTX0VS UihwY2ktPmRiaV9iYXNlKSkKPj4gLQkJcmV0dXJuIFBUUl9FUlIocGNpLT5kYmlfYmFzZSk7Cj4+ IC0KPj4gIAlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2VfYnluYW1lKHBkZXYsIElPUkVTT1VS Q0VfTUVNLCAiY29uZmlnIik7Cj4+ICAJcHAtPnZhX2NmZzBfYmFzZSA9IGRldm1fcGNpX3JlbWFw X2NmZ19yZXNvdXJjZShkZXYsIHJlcyk7Cj4+ICAJaWYgKElTX0VSUihwcC0+dmFfY2ZnMF9iYXNl KSkKPj4gQEAgLTgxOCwxMyArODEzLDYgQEAgc3RhdGljIGludCBfX2luaXQga3NfcGNpZV9hZGRf cGNpZV9wb3J0KHN0cnVjdCBrZXlzdG9uZV9wY2llICprc19wY2llLAo+PiAgCj4+ICAJcHAtPnZh X2NmZzFfYmFzZSA9IHBwLT52YV9jZmcwX2Jhc2U7Cj4+ICAKPj4gLQlyZXMgPSBwbGF0Zm9ybV9n ZXRfcmVzb3VyY2VfYnluYW1lKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAiYXBwIik7Cj4+IC0Ja3Nf cGNpZS0+dmFfYXBwX2Jhc2UgPSBkZXZtX2lvcmVtYXBfcmVzb3VyY2UoZGV2LCByZXMpOwo+PiAt CWlmIChJU19FUlIoa3NfcGNpZS0+dmFfYXBwX2Jhc2UpKQo+PiAtCQlyZXR1cm4gUFRSX0VSUihr c19wY2llLT52YV9hcHBfYmFzZSk7Cj4+IC0KPj4gLQlrc19wY2llLT5hcHAgPSAqcmVzOwo+PiAt Cj4+ICAJcHAtPm9wcyA9ICZrc19wY2llX2hvc3Rfb3BzOwo+PiAgCXJldCA9IGR3X3BjaWVfaG9z dF9pbml0KHBwKTsKPj4gIAlpZiAocmV0KSB7Cj4+IEBAIC04OTUsNiArODgzLDggQEAgc3RhdGlj IGludCBfX2luaXQga3NfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ PiAgCXN0cnVjdCBkd19wY2llICpwY2k7Cj4+ICAJc3RydWN0IGtleXN0b25lX3BjaWUgKmtzX3Bj aWU7Cj4+ICAJc3RydWN0IGRldmljZV9saW5rICoqbGluazsKPj4gKwlzdHJ1Y3QgcmVzb3VyY2Ug KnJlczsKPj4gKwl2b2lkIF9faW9tZW0gKmJhc2U7Cj4+ICAJdTMyIG51bV92aWV3cG9ydDsKPj4g IAlzdHJ1Y3QgcGh5ICoqcGh5Owo+PiAgCXUzMiBudW1fbGFuZXM7Cj4+IEBAIC05MTEsNiArOTAx LDE5IEBAIHN0YXRpYyBpbnQgX19pbml0IGtzX3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPj4gIAlpZiAoIXBjaSkKPj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4+ICAKPj4g KwlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2VfYnluYW1lKHBkZXYsIElPUkVTT1VSQ0VfTUVN LCAiYXBwIik7Cj4+ICsJa3NfcGNpZS0+dmFfYXBwX2Jhc2UgPSBkZXZtX2lvcmVtYXBfcmVzb3Vy Y2UoZGV2LCByZXMpOwo+PiArCWlmIChJU19FUlIoa3NfcGNpZS0+dmFfYXBwX2Jhc2UpKQo+PiAr CQlyZXR1cm4gUFRSX0VSUihrc19wY2llLT52YV9hcHBfYmFzZSk7Cj4+ICsKPj4gKwlrc19wY2ll LT5hcHAgPSAqcmVzOwo+PiArCj4+ICsJcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlX2J5bmFt ZShwZGV2LCBJT1JFU09VUkNFX01FTSwgImRiaWNzIik7Cj4+ICsJYmFzZSA9IGRldm1fcGNpX3Jl bWFwX2NmZ19yZXNvdXJjZShkZXYsIHJlcyk7Cj4+ICsJaWYgKElTX0VSUihiYXNlKSkKPj4gKwkJ cmV0dXJuIFBUUl9FUlIoYmFzZSk7Cj4+ICsKPj4gKwlwY2ktPmRiaV9iYXNlID0gYmFzZTsKPj4g IAlwY2ktPmRldiA9IGRldjsKPj4gIAlwY2ktPm9wcyA9ICZrc19wY2llX2R3X3BjaWVfb3BzOwo+ PiAgCj4+IC0tIAo+PiAyLjE3LjEKPj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK