Re: [PATCH 2/2 v5] Watchdog: Add marvell GTI watchdog driver

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 03/05/2023 14:10, Bharat Bhushan wrote:
> This patch add support for Marvell GTI watchdog.  Global timer
> unit (GTI) support hardware watchdog timer. Software programs
> watchdog timer to generate interrupt on first timeout, second
> timeout is configured to be ignored and system reboots on
> third timeout.
> 
> Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>



> +
> +static void gti_clk_disable_unprepare(void *data)
> +{
> +	clk_disable_unprepare(data);
> +}
> +
> +static int gti_wdt_get_cntfrq(struct platform_device *pdev,
> +			      struct gti_wdt_priv *priv)
> +{
> +	int err;
> +
> +	priv->sclk = devm_clk_get(&pdev->dev, NULL);
> +	if (IS_ERR(priv->sclk))
> +		return PTR_ERR(priv->sclk);

NAK. Undocumented property. Test your DTS. There is no way it was
working. Either you did not test DTS against bindings or you did not
test driver and DTS together.

Better actually to upstream your DTS...

Best regards,
Krzysztof