From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCEBC433C1 for ; Fri, 26 Mar 2021 14:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09A30619F2 for ; Fri, 26 Mar 2021 14:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbhCZOdg (ORCPT ); Fri, 26 Mar 2021 10:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbhCZOde (ORCPT ); Fri, 26 Mar 2021 10:33:34 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E9CC0613AA; Fri, 26 Mar 2021 07:33:34 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id DBF5D1F40DAB Message-ID: <9af079bccb3642af9c26319e94b16defea52886f.camel@collabora.com> Subject: Re: [PATCH v2 06/10] media: dt-bindings: Document SAMA5D4 VDEC bindings From: Ezequiel Garcia To: Rob Herring , Emil Velikov Cc: Philipp Zabel , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, Nicolas Ferre , Frank Rowand , devicetree@vger.kernel.org Date: Fri, 26 Mar 2021 11:33:25 -0300 In-Reply-To: <20210324151715.GA3070006@robh.at.kernel.org> References: <20210311154055.3496076-1-emil.l.velikov@gmail.com> <20210311154055.3496076-7-emil.l.velikov@gmail.com> <20210324151715.GA3070006@robh.at.kernel.org> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, Thanks for reviewing. On Wed, 2021-03-24 at 09:17 -0600, Rob Herring wrote: > On Thu, Mar 11, 2021 at 03:40:51PM +0000, Emil Velikov wrote: > > From: Emil Velikov > > > > Add devicetree binding documentation for the Hantro G1/G2 VDEC on > > the Microchip SAMAS5D4 SoC. > > > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: devicetree@vger.kernel.org> > > Signed-off-by: Emil Velikov > > --- > > v2 > >  - Newly introduced > >  - s/Atmel/Microchip/ (Nicolas) > >  - Drop leading 0 in node name/address > > --- > >  .../media/microchip,sama5d4-vdec.yaml         | 59 +++++++++++++++++++ > >  1 file changed, 59 insertions(+) > >  create mode 100644 Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml b/Documentation/devicetree/bindings/media/microchip,sama5d4- > > vdec.yaml > > new file mode 100644 > > index 000000000000..9cb2c0295d54 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/microchip,sama5d4-vdec.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/media/microchip,sama5d4-vdec.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Hantro G1 VPU codec implemented on Microchip SAMA5D4 SoCs > > + > > +maintainers: > > +  - Emil Velikov > > + > > +description: > > +  Hantro G1 video decode accelerator present on Microchip SAMA5D4 SoCs. > > + > > +properties: > > +  compatible: > > +    const: microchip,sama5d4-vdec > > + > > +  reg: > > +    maxItems: 1 > > + > > +  interrupts: > > +    maxItems: 1 > > + > > +  interrupt-names: > > +    items: > > +      - const: vdec > > Why do you need a name? *-names are used to distinguish multiple entries > and don't add anything if only a single entry. > I guess you are right. I was about to argue that it makes backwards compatibility easier, but I suspect that's not the case either. > > + > > +  clocks: > > +    maxItems: 1 > > + > > +  clock-names: > > +    items: > > +      - const: vdec_clk > > And here too? These are typically named for either the name of input > signal (hclk, aclk, etc.) or function ('core', 'bus', etc.). > Indeed, "core" might be a better choice. But it seems we don't need names here. Thanks, Ezequiel