devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply
@ 2023-07-20 11:55 Krzysztof Kozlowski
  2023-07-20 11:55 ` [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode Krzysztof Kozlowski
  2023-08-10  7:54 ` [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Linus Walleij
  0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-20 11:55 UTC (permalink / raw)
  To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

According to bindings and Linux driver, there is no VDDIO but VIO
supply:

  ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
index 37e59403c01f..469e61c9a349 100644
--- a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
+++ b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
@@ -192,7 +192,7 @@ synaptics@4b {
 				#size-cells = <0>;
 				reg = <0x4b>;
 				vdd-supply = <&ab8500_ldo_aux1_reg>;
-				vddio-supply = <&db8500_vsmps2_reg>;
+				vio-supply = <&db8500_vsmps2_reg>;
 				pinctrl-names = "default";
 				pinctrl-0 = <&synaptics_tvk_mode>;
 				interrupt-parent = <&gpio2>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode
  2023-07-20 11:55 [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Krzysztof Kozlowski
@ 2023-07-20 11:55 ` Krzysztof Kozlowski
  2023-08-10  7:54   ` Linus Walleij
  2023-08-10  7:54 ` [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Linus Walleij
  1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-20 11:55 UTC (permalink / raw)
  To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-kernel, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

There is no syna,nosleep property in Synaptics RMI4 touchscreen:

  ste-hrefprev60-tvk.dtb: synaptics@4b: rmi4-f01@1: 'syna,nosleep' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
index 469e61c9a349..7448135e25f6 100644
--- a/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
+++ b/arch/arm/boot/dts/st/ste-href-tvk1281618-r2.dtsi
@@ -200,7 +200,7 @@ synaptics@4b {
 
 				rmi4-f01@1 {
 					reg = <0x1>;
-					syna,nosleep = <1>;
+					syna,nosleep-mode = <1>;
 				};
 				rmi4-f11@11 {
 					reg = <0x11>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply
  2023-07-20 11:55 [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Krzysztof Kozlowski
  2023-07-20 11:55 ` [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode Krzysztof Kozlowski
@ 2023-08-10  7:54 ` Linus Walleij
  2023-09-24 18:55   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2023-08-10  7:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel

On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> According to bindings and Linux driver, there is no VDDIO but VIO
> supply:
>
>   ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Patch applied!
Excellently shows how the schema files find real bugs in the DTS files!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode
  2023-07-20 11:55 ` [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode Krzysztof Kozlowski
@ 2023-08-10  7:54   ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2023-08-10  7:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel

On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> There is no syna,nosleep property in Synaptics RMI4 touchscreen:
>
>   ste-hrefprev60-tvk.dtb: synaptics@4b: rmi4-f01@1: 'syna,nosleep' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Patch applied!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply
  2023-08-10  7:54 ` [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Linus Walleij
@ 2023-09-24 18:55   ` Krzysztof Kozlowski
  2023-09-25  9:22     ` Linus Walleij
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-24 18:55 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel

On 10/08/2023 09:54, Linus Walleij wrote:
> On Thu, Jul 20, 2023 at 1:55 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> 
>> According to bindings and Linux driver, there is no VDDIO but VIO
>> supply:
>>
>>   ste-hrefprev60-tvk.dtb: synaptics@4b: Unevaluated properties are not allowed ('vddio-supply' was unexpected)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Patch applied!
> Excellently shows how the schema files find real bugs in the DTS files!

It seems it is not in the linux-next (one month later). Shall I take it?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply
  2023-09-24 18:55   ` Krzysztof Kozlowski
@ 2023-09-25  9:22     ` Linus Walleij
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2023-09-25  9:22 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
	devicetree, linux-kernel

On Sun, Sep 24, 2023 at 8:55 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> > Patch applied!
> > Excellently shows how the schema files find real bugs in the DTS files!
>
> It seems it is not in the linux-next (one month later). Shall I take it?

Ooops. Just me not keeping track of my TODO list as usual.
Sent a pull request now.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-09-25  9:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 11:55 [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Krzysztof Kozlowski
2023-07-20 11:55 ` [PATCH 2/2] ARM: dts: st: href-tvk1281618: correct touchscreen syna,nosleep-mode Krzysztof Kozlowski
2023-08-10  7:54   ` Linus Walleij
2023-08-10  7:54 ` [PATCH 1/2] ARM: dts: st: href-tvk1281618: fix touchscreen VIO supply Linus Walleij
2023-09-24 18:55   ` Krzysztof Kozlowski
2023-09-25  9:22     ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).