From: Ajit Pandey <ajitp@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: plai@codeaurora.org, bgoswami@codeaurora.org,
srinivas.kandagatla@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header
Date: Sat, 16 May 2020 23:44:32 +0530 [thread overview]
Message-ID: <9b02abcd-23a0-8edb-674a-44358a516015@codeaurora.org> (raw)
On 5/14/2020 10:18 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:
>
>> +#define MI2S_PRIMARY 0
>> +#define MI2S_SECONDARY 1
>> +
>> +#define LPASS_MCLK0 0
> These look like they could use namespacing. Is primary/secondary
> perhaps something that could be a boolean property?
Primary/secondary is a dai id and can be from 0-4 (SC7180 soc driver
support only 0-1 at present). Such id is mainly used in dtsi and machine
driver to do dai id based configuration for a soc hence we placed them
in dt headers file for now.
next reply other threads:[~2020-05-16 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 18:14 Ajit Pandey [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-18 9:22 [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b02abcd-23a0-8edb-674a-44358a516015@codeaurora.org \
--to=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).