From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E94C49CF38 for ; Thu, 3 Sep 2026 11:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436412; cv=none; b=euVjsosBCG7BzKd3VPOkFf1oI+7rNLIh8IoJT9HEGwUVd+r86q+5NGXcPQ3gZnPQ0+F8alVbBvOvBMEvx5Mzt02Q/lReOIfPJX6Gj09n+ogG6x0oL64TP5v00zbkQ4gbgpKd1JsFTy4zpmgmcyoPx6q/HF74/hNNVetInLzUyjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788436412; c=relaxed/simple; bh=n5ctRfXvrUaJX4olBTeuOGHj+PO5gbXXUrz1f2Frvss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FO+a0SQ4vY9XSTeMPK8bf9whq4RqmyIYx4J09X7gJdKQgFFdwH69eLV6ZWiOVEiFh9ooiQs0PKXe3sILsYiH31gDn4Qt/S1o0xNlRq5sQcVPwXaobwkvhbkd/1j1ngLoNgmkbxvm+wgit85u8+L35ESLfCXz9MbpygKwITV9wuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gL73X60l; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gL73X60l" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5aeb906d6c6so278103e87.2 for ; Thu, 03 Sep 2026 04:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1788436404; x=1789041204; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=YlAxcekko1WzQ9ej7nCP/3I5A9S1XkCyAocKTij2/Qs=; b=gL73X60lhEAN95JgdMhMGAtLsNyJpdOj5nIWnsTUd0mBYojsbW5HfXrMU2ekHbt81H bVKDgJz2mokkmYRMgrZZKQ4XA6C9FPXXgi/zv/03m8s+FQ8T/KXHWw4UTphcnaHsmovQ pyWyb+cU9zRCgEx3F8jdbabaYrJnxeSHld0kjT5HUR4L2nbD97U+bf2+mjJifOLOLMW/ KZSFULryGDPt4cdHJYL3305StOthvSIIgjyY4ea+dctVBHPmhpkARO+eyzdreBjDDtHn ULz5JPIzbmYvhYxW09X5v8XmQpQFkTcblGh9f5K4AkpoMXCfDHCG0RuVU8dCVoCpTiHO ELNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788436404; x=1789041204; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YlAxcekko1WzQ9ej7nCP/3I5A9S1XkCyAocKTij2/Qs=; b=MRhmvtpvnoVvt33iy6PwDaobQ1GCXNM5Yy2TnWROEw0ZGt9sj1/XgIyEH17+x/kJZW TiASOKdyAm24ItV2x8ykloWkcPcWhzLMlIedMngK/ldyTV7EBIMoKLF0eiGG34iIFtJK RSczwemwHZrHuNcIxAFRtY26g2UDG21DfnJmLxZU8on4MW8zPSERN2OfSQv0kh9d+OBS KWytLHkNcYd3DtyUjA5yWCsh4z/iEQbeB6qWuLYAAR3hlsK3JgVjqHvCFhO35cI9BqPX +1+EP/jCw0AZje0+etx0JnqipMyqRU0guUR0kg2LHD5tQ+omBh3PghqZ5uArYViI1a9Q KNsA== X-Forwarded-Encrypted: i=1; AKwUvByP0glbX9jRHkLTWJ1sjAaS7vIiyUY/VyMRCw96ZeB7YMpvtcjNAVmebqBUD9hHBUS6cdPsHpmRi60x@vger.kernel.org X-Gm-Message-State: AFuF++lIcC4EAy5JA5TOnUrXjTfY3j0s283grL4YOS9lX5RBzhx+VQY1 EXAht9/qA701GStXbGZKVD0UDor7XjNCZWqdwaTjn0Dubb/6Nmi94lvrLm630eV/7/c= X-Gm-Gg: AYBFou2/pHz1bKEz5RYC9itFwg6NNVWVXERY2UCa1lvSif1tMGUqtmdfJSn4XuJOEX2 4iwfvDuGo+Wv/nKTSPLBtKg2JrYxluQWkMSR46dnJJyJXmpTVsNP72J51xxlt8FdB+U8lcL+K+h P3PLLITZHXDaUQBZ5PP9UpzU0skb1cqnSyIpAb2E86swocj6JBQ6FQYwZFZiMwBfx88aeDKER9t pBrtDXsVcJJwAyihCqu3RWv0kWJdwUl1sdzLSpSKddQ1tMZ5vUNupeqnoWQeRMNbO4McAolrizT 8ISNQBlNx2K02VD/Z5ifLEpBaf0ID34oTD13PAHBduTyB4sp5OFc/Lrs8BDvc9Zktf/E77TTXxp iz37DxzAHlQy60U60jEa4M+dD7pV4LzxUezuSEStG8w948LstqGL9aIT3NZqDjXcqUnw+Nxy/ZX GFmNsoP4CdNNJLJF5lzazAdp6OkL6BwMOlIqivpBoEQBNSeUn1ui/L+sYn9lbTm8dQiCmiKeSR5 0P1K/EW9CthF8MZp8UzASP9jsIMyfhdBGZrd9Dmxw== X-Received: by 2002:a05:6512:2350:b0:5b6:4ae:19ef with SMTP id 2adb3069b0e04-5b608810e61mr1613364e87.5.1788436404014; Thu, 03 Sep 2026 04:53:24 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a34ad21ef8sm11778701fa.28.2026.09.03.04.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 04:53:23 -0700 (PDT) Message-ID: <9b0ac659-999a-4caa-8578-f34a39a67e4f@linaro.org> Date: Thu, 3 Sep 2026 14:53:14 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260901-x1e-csi2-phy-v16-0-dd863b929080@linaro.org> <20260901-x1e-csi2-phy-v16-1-dd863b929080@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20260901-x1e-csi2-phy-v16-1-dd863b929080@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/1/26 23:15, Bryan O'Donoghue wrote: > Add a base schema for the MIPI CSI2 PHYs on Qualcomm SoCs. This PHY > supports both DPHY and CPHY operation. A special mode of DPHY operation - > called variously split-mode or combo-mode also allows for two sensors to be > connected to one PHY. > > The submitted binding here describes the DPHY modes of operation only. CPHY > is left to future work. Like I've said in v14 review, the statement above is incorrect, and it has to be changed, for whatever reason it hasn't happened so far. From https://lore.kernel.org/all/1e1bc17a-4c7a-4c08-b0c8-2a2ff31fe870@linaro.org/ >>> C-PHY bus type is also well described by this version of the bindings. > Suggested-by: Vladimir Zapolskiy > Signed-off-by: Bryan O'Donoghue > --- > .../bindings/phy/qcom,x1e80100-csi2-phy.yaml | 222 +++++++++++++++++++++ > 1 file changed, 222 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > new file mode 100644 > index 0000000000000..17de0701eb103 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > @@ -0,0 +1,222 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/qcom,x1e80100-csi2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm X1E80100 SoC CSI2 PHY > + > +maintainers: > + - Bryan O'Donoghue > + > +description: > + Qualcomm MIPI CSI2 C-PHY/D-PHY combination PHY. Connects MIPI CSI2 sensors > + to Qualcomm's Camera CSI Decoder. The PHY supports both C-PHY and D-PHY > + modes. > + > +properties: > + compatible: > + const: qcom,x1e80100-csi2-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: core > + - const: timer > + - const: ahb > + > + interrupts: > + maxItems: 1 > + > + operating-points-v2: true > + > + opp-table: > + type: object > + > + power-domains: > + items: > + - description: Titan Top GDSC - Titan ISP Block, Global Distributed Switch Controller. > + - description: MMCX voltage rail > + - description: MXC or MXA voltage rail > + > + power-domain-names: > + items: > + - const: top > + - const: mmcx > + - const: mx > + > + vdda-0p9-supply: > + description: Phandle to a 0.9V regulator supply to a PHY. > + > + vdda-1p2-supply: > + description: Phandle to 1.2V regulator supply to a PHY. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + description: > + Sensor input. Always present. A single sensor is described by a > + single endpoint with the clock lane at position 0 and one to four > + data lanes. > + > + DPHY split mode, where two independent sensors share the same PHY, > + is described by two endpoints, each with its own clock lane position; > + endpoint@0 with clock-lanes = <0> and one or two data-lanes and > + endpoint@1 with clock-lanes = <3> and one data lane. > + > + unevaluatedProperties: false > + > + patternProperties: > + "^endpoint(@[01])?$": > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + properties: > + bus-type: > + enum: > + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY > + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY > + > + clock-lanes: > + maxItems: 1 > + > + data-lanes: > + minItems: 1 > + maxItems: 4 > + items: > + minimum: 1 > + maximum: 4 > + description: > + Data lane positions following this endpoint's clock > + lane. Positions are a per-port logical numbering, not > + package pad or ball positions. > + > + required: > + - bus-type A review comment given to v14 is still applicable, 'bus-type' property should be set as optional with D-PHY mode fallback. > + - data-lanes > + - clock-lanes Here 'clock-lanes' is a truly optional proiperty since its value is immutable in each endpoint, it should be removed from the list of required properties. Also 'clock-lanes' are not expected to be found in C-PHY bus type case. > + - remote-endpoint > + > + allOf: > + - if: > + required: > + - endpoint@1 > + then: > + properties: > + endpoint@0: > + properties: > + clock-lanes: > + const: 0 > + data-lanes: > + maxItems: 2 > + endpoint@1: > + properties: > + clock-lanes: > + const: 3 > + data-lanes: > + items: > + - const: 4 > + required: > + - endpoint@0 > + else: > + patternProperties: > + "^endpoint(@0)?$": > + properties: > + clock-lanes: > + const: 0 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output to the CAMSS CSID controller. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - operating-points-v2 > + - power-domains > + - power-domain-names > + - vdda-0p9-supply > + - vdda-1p2-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + phy@ace4000 { > + compatible = "qcom,x1e80100-csi2-phy"; > + reg = <0x0ace4000 0x2000>; > + > + clocks = <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CORE_AHB_CLK>; > + clock-names = "core", > + "timer", > + "ahb"; > + > + interrupts = ; > + > + operating-points-v2 = <&csiphy_opp_table>; > + > + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>, > + <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MX>; > + power-domain-names = "top", > + "mmcx", > + "mx"; > + > + vdda-0p9-supply = <&vreg_l2c_0p9>; > + vdda-1p2-supply = <&vreg_l1c_1p2>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + csiphy0_in: endpoint { > + bus-type = ; > + clock-lanes = <0>; > + data-lanes = <1 2 3 4>; > + remote-endpoint = <&sensor_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + csiphy0_out: endpoint { > + remote-endpoint = <&csid_in>; > + }; > + }; > + }; > + > + csiphy_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&rpmhpd_opp_low_svs_d1>, > + <&rpmhpd_opp_low_svs_d1>; > + }; > + }; > + }; > Apart of a few minor comments above, everything else looks good to me. -- Best wishes, Vladimir