From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA551C4167B for ; Fri, 25 Nov 2022 12:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbiKYMM0 (ORCPT ); Fri, 25 Nov 2022 07:12:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbiKYMMY (ORCPT ); Fri, 25 Nov 2022 07:12:24 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 933F14509E for ; Fri, 25 Nov 2022 04:12:22 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id b3so6616988lfv.2 for ; Fri, 25 Nov 2022 04:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WIDCe1F2pbbd2Mgy1MXrte4UDEybWJsDPNOb5ZCnmZQ=; b=UoBk6bEFZdln6Gqli1w+RnWCFscF0VbAqS8Ag3LpE2o4H48mryNm6HdqsmHags6EXS xWOJNeT6QcZWbiloClD2sl8WKeKQxA/oVklAnjTYhvwL0MBIZZbi0m/y1XM39p/LtRe6 XpN1GYXTREaIVvk1MIvWnXe6oVJVfxwCY60WiH5GTVCDt+JtTHdJqv9kjD34DsxOgiC1 Ri5SWYvCQFnsJDigQUQa3BP50L8u1oWeVq90QxGOBOZSPsFaFjX7LT0bkVQILYZGu9Bo HB0m3lHG9D9VJ2rtsyhYlFf8TOnWdfoUOZnhPu5vISCEQa0tbrgHTG6kp+nI0tM8MpRc P/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WIDCe1F2pbbd2Mgy1MXrte4UDEybWJsDPNOb5ZCnmZQ=; b=VuB0ppMhzftvx9/bE6xwai05ajLh4xqGHpoVMYiQkl92oKzUmrCcGETkT4rWvcEyPW RCvoW/gdJe06eaqiucdRt1Z7X0AeY3UVyvlPNJtL8bFKkPVUblO1LTjUEM++h/l6h2gD 5drBmtxbk6v/D4jiR2R6KEbQNELB+nIqMO25ZHrkRgF3Ckukq8LFVsNqy0H9IlkX0oyC MYVgW4fteLicFwMfbKlTLIJ1s6JnC/Vaa3LIANYP1T75LS6cWRT3MhXz55Z3Y8qgVR8Y GJexczPnPbnNYjDk6YE4mbieGAmy11omiF1sIi7OqvgP9xSxtMEK2Uv/MvcLu00QaYfh V5Zw== X-Gm-Message-State: ANoB5plynL9wjeXDJtHOcvwEK7ec2dA0HVuVrJxbuWuTc6+G5hpshgIZ GeRqOIlLfRVGsrWHlBcBGLyx7g== X-Google-Smtp-Source: AA0mqf7AYDN1omQtlSSqKyibMA+E7LIJY49giATJQ8eBdw3MdfOTWsmmF57QotBfyUz6z3524orkhg== X-Received: by 2002:ac2:4f0c:0:b0:4ac:2f5f:5c9b with SMTP id k12-20020ac24f0c000000b004ac2f5f5c9bmr6226180lfr.206.1669378340651; Fri, 25 Nov 2022 04:12:20 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id j17-20020a056512399100b004b257fef958sm508060lfu.94.2022.11.25.04.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 04:12:20 -0800 (PST) Message-ID: <9b0f8312-2caa-b9f3-edf3-1b720532f559@linaro.org> Date: Fri, 25 Nov 2022 13:12:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v4 6/7] dt-bindings: cache: r9a07g043f-l2-cache: Add DT binding documentation for L2 cache controller Content-Language: en-US To: "Lad, Prabhakar" Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guo Ren , Jisheng Zhang , Atish Patra , Anup Patel , Andrew Jones , Nathan Chancellor , Philipp Tomsich , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Biju Das , Lad Prabhakar References: <20221124172207.153718-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20221124172207.153718-7-prabhakar.mahadev-lad.rj@bp.renesas.com> <70d1bfde-f57f-1741-08d3-23e362793595@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/11/2022 11:34, Lad, Prabhakar wrote: >>> +/* Device, Non-bufferable */ >>> +#define AX45MP_PMACFG_MTYP_DEV_NON_BUF (0 << 2) >>> +/* Device, bufferable */ >>> +#define AX45MP_PMACFG_MTYP_DEV_BUF (1 << 2) >>> +/* Memory, Non-cacheable, Non-bufferable */ >>> +#define AX45MP_PMACFG_MTYP_MEM_NON_CACHE_NON_BUF (2 << 2) >>> +/* Memory, Non-cacheable, Bufferable */ >>> +#define AX45MP_PMACFG_MTYP_MEM_NON_CACHE_BUF (3 << 2) >> >> What are all these? They don't look like flags, because 3 = 1 | 2... >> they don't look like constants, because we do not use shifts in >> constants. Are these some register values? I also do not see the header >> being used in the code, so why having a bindings header if it is not >> used (DTS is not usage...)? >> > These are register bit values for the MTYP[5:2] field. The DTS example > in the binding doc (above) uses these macros. I haven't included the > DTS/I patches with this patchset yet do think I should? Then why storing it as bindings? Bindings headers describe the interface implemented by drivers and used by DTS, but this is not implemented by drivers. Best regards, Krzysztof