From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A40FA3741 for ; Tue, 25 Oct 2022 16:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232596AbiJYQCk (ORCPT ); Tue, 25 Oct 2022 12:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230463AbiJYQCj (ORCPT ); Tue, 25 Oct 2022 12:02:39 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2A0419044A for ; Tue, 25 Oct 2022 09:02:37 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id t25so8381573qkm.2 for ; Tue, 25 Oct 2022 09:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7pGkJc93t4XHow6PfRqMAHBDJ4RPCkSR1Pf3xadIrCU=; b=SIe8n72+y1kEIAoch9h1uTh83dmjyrtwUDXwR49pPtgKaa8fiocc+xDxIeuNNF1xGy J4cAQ/I4jr8DUXLZyJ92bDYWfayqzdRNuJrZK6lJSpxDKrFfbXdz4FjPuW1RG9smqVG4 9q218uQkBOAvI/wYNnJcmTRdlTO0dLDTevZSACp7aznSNuiZRKIvveeYCIfzIQ7SZmXV PwpOVXPzSnI7GCjVcg/IJ83YD/K7rrwvfPmqRK/qXDdE5/kpnTNbdzJTT5TcmqUckKam BdEMfSsDFNH9Xhmyv6s5OCiaUoFDYSmBXF28UU5UMLadV5osVNB4nB/JsubNeBLbXSPh L2Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pGkJc93t4XHow6PfRqMAHBDJ4RPCkSR1Pf3xadIrCU=; b=W5+hmWKe1ROM+/zGkiyNvNgE2oqeGQJ8UR93GFclFXrYzA/zN4VSLzjHnwyPmS1MbI mS3bOGj8j0bdvgYUM+PQXv8DfQ5yp8ImSk3A/90/t+dFvoDWR8RHLd5yQEf2dYksfzU1 hPhPdR6Jru+vY4mpLyAfWJ5A1FiRaoBFePIlrAJMiGBb0czU/K+9mDvGTrm6GRwqcl1r 2jbQ4KKYwhnjIDHP5xXg3s8xL8NF0uxA65UfIosGqpHvwFgTV8OBWhWWtsiR42I0Ib9c HugCJidnVBTDr2ml9NEDSDO83wIb7+B8mkZzI38M9y1u2P59rt2qaOuxWSe6MTF5sIqt jHUQ== X-Gm-Message-State: ACrzQf1EdeqqWtnvk2WKY+VXBbcrIWbGWObEQMr/yU9c8W3GT562DwYF TowuEyBaFh8dHXA6KquGDTmrCQ== X-Google-Smtp-Source: AMsMyM6pX7Eil0FyKEI9e8Ft2/z18UKFTF36FYyYjt8eQKd6AWyFYhXNIbzd6/rZfO6ndBKWu9Wzjg== X-Received: by 2002:a05:620a:1212:b0:6ee:a8ec:c07f with SMTP id u18-20020a05620a121200b006eea8ecc07fmr28121292qkj.334.1666713756708; Tue, 25 Oct 2022 09:02:36 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id h2-20020ac81382000000b0038b684a1642sm1809136qtj.32.2022.10.25.09.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 09:02:35 -0700 (PDT) Message-ID: <9b21fb34-4035-c43e-0e4e-896c2d7ba218@linaro.org> Date: Tue, 25 Oct 2022 12:02:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 5/5] arm64: dts: apple: Add CPU topology & cpufreq nodes for t8103 Content-Language: en-US To: Hector Martin , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger Cc: Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Ulf Hansson , Marc Zyngier , Mark Kettenis , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221024043925.25379-1-marcan@marcan.st> <20221024043925.25379-6-marcan@marcan.st> From: Krzysztof Kozlowski In-Reply-To: <20221024043925.25379-6-marcan@marcan.st> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/10/2022 00:39, Hector Martin wrote: > Add the missing CPU topology/capacity information and the cpufreq nodes, > so we can have CPU frequency scaling and the scheduler has the > information it needs to make the correct decisions. > Thank you for your patch. There is something to discuss/improve. > + > timer { > compatible = "arm,armv8-timer"; > interrupt-parent = <&aic>; > @@ -124,6 +298,18 @@ soc { > ranges; > nonposted-mmio; > > + cpufreq_e: cpufreq@210e20000 { Node name: performance-controller > + compatible = "apple,t8103-cluster-cpufreq", "apple,cluster-cpufreq"; > + reg = <0x2 0x10e20000 0 0x1000>; > + #performance-domain-cells = <0>; > + }; > + > + cpufreq_p: cpufreq@211e20000 { Ditto > + compatible = "apple,t8103-cluster-cpufreq", "apple,cluster-cpufreq"; > + reg = <0x2 0x11e20000 0 0x1000>; > + #performance-domain-cells = <0>; > + }; > + Krzysztof