From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88415C4167B for ; Fri, 23 Dec 2022 09:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236086AbiLWJOG (ORCPT ); Fri, 23 Dec 2022 04:14:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235897AbiLWJOF (ORCPT ); Fri, 23 Dec 2022 04:14:05 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 864A220BC1 for ; Fri, 23 Dec 2022 01:14:04 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id cf42so6378915lfb.1 for ; Fri, 23 Dec 2022 01:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ce317vF268IfvnfP9+p1VVXhxTBGucn4dlvIXgjdsZU=; b=lbcLMP6Q0HWuQk3H+EUrd087gzWF425/OhsFFMYt4hGdRdOUV6SaUQNRZLuSlCTujO 4GhCLyhanmjjP2Avp9EBcI7tdkVUqbMns1YcHUeZZEVO3t/91c+NG5QX2mYaXiPXSqt1 In8EMzGzBFt0nWOOEL18D5yOD07DhJbYXiDNwDDJI91NsAq1escZVkv258nOteTgh2EV WBngyAjP6aDsDZ2mGOcKEJcbKVcwv/BRrncxVuk1dke6OFxey+G+LocDd65zE9x+HdxI BLWI/m/D1joMjV8cCnpDB4tcKcMr+vJ4GBS/OabCU148XwTIv7YP110nGkDBoLgUzzy4 1B/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ce317vF268IfvnfP9+p1VVXhxTBGucn4dlvIXgjdsZU=; b=pZ8RnYhUyvS0ZiB/EAXLLNcMIK6SvUo80km4Ahpf5ijZ4h1vPRL0bac1gDUZ0lwlYJ c2LVUrRgGUW2ddM5iZRZ0DGsPI+ziDkmh5OH/+ZzOsNYVPlF4LAx0ORH4d/fymn6wCW5 oZ/0EHeszEpvT0Q6DBkPtNh6+GffwSW5uXc8+PGZp7pJqBgrH1VuSQBHpW2UFpAy2XcV 11UT6vHwgBS1Cc54bmHb1XNtjCcwwj6Rm5fRz1v9t3IbMK8YEzm1SpPICNilfIMnpgeW KmaswoZM8O19oBF6+tOdhyhedJuW6Yyo5p4WhXo1XqgM6vPP/USWd3WggilV2Z2mmoFH M4Nw== X-Gm-Message-State: AFqh2krdDiJtT81Fg31BHMSrkP+IipX7z9p49X5k4ajuPFHglCwKc5ub ffAID11E0vOnFCA12Be9CrHk0A== X-Google-Smtp-Source: AMrXdXuvuxfOoh7btFzaHq0D7UEX6Vdsw/DhoOg+jC0H2+ELHxHS4cMpuHtdiGRPa7224JaeRiKhkw== X-Received: by 2002:a05:6512:70a:b0:4c0:4214:cd2c with SMTP id b10-20020a056512070a00b004c04214cd2cmr2211602lfs.43.1671786842930; Fri, 23 Dec 2022 01:14:02 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id s16-20020a056512315000b0049876c1bb24sm440414lfi.225.2022.12.23.01.14.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 01:14:02 -0800 (PST) Message-ID: <9b435fb2-9ba9-e985-e132-e10f793ca659@linaro.org> Date: Fri, 23 Dec 2022 10:14:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 5/7] arm64: dts: qcom: sc7280: audioreach: Add CGCR reset property Content-Language: en-US To: Srinivasa Rao Mandadapu , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, konrad.dybcio@linaro.org References: <1671702170-24781-1-git-send-email-quic_srivasam@quicinc.com> <1671702170-24781-6-git-send-email-quic_srivasam@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1671702170-24781-6-git-send-email-quic_srivasam@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/12/2022 10:42, Srinivasa Rao Mandadapu wrote: > Add CGCR register reset property for both RX and TX soundwire > slave devices. > > Signed-off-by: Srinivasa Rao Mandadapu > Tested-by: Mohammad Rafi Shaik > --- > This patch depends on: > -- https://lore.kernel.org/linux-clk/1671618061-6329-1-git-send-email-quic_srivasam@quicinc.com/ > > .../arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > index a750f05..ce5d69e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi > @@ -217,3 +217,12 @@ > }; > }; > }; > + > +&swr0 { > + resets = <&lpasscc LPASS_AUDIO_SWR_RX_CGCR>; > +}; > + > +&swr1 { Why here not in SoC DTSI? > + resets = <&lpasscc LPASS_AUDIO_SWR_TX_CGCR>; > +}; > + Are you adding stray new lines? Best regards, Krzysztof