From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luo Jie <quic_luoj@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
quic_kkumarcs@quicinc.com, quic_suruchia@quicinc.com,
quic_soni@quicinc.com, quic_pavir@quicinc.com,
quic_souravp@quicinc.com, quic_linchen@quicinc.com,
quic_leiwei@quicinc.com
Subject: Re: [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree
Date: Wed, 10 Jan 2024 12:56:20 +0100 [thread overview]
Message-ID: <9b44a04d-3d04-4fdb-a51c-b0e4b72af558@linaro.org> (raw)
In-Reply-To: <20240110112059.2498-4-quic_luoj@quicinc.com>
On 10/01/2024 12:20, Luo Jie wrote:
> Add the MDIO device tree of ipq5332.
Subject: drop "device tree", it is obvious. Commit msg: say something
more instead of copying the subject. Or better squash the entire patch.
>
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 44 +++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index bc89480820cb..e6c780e69d6e 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -214,6 +214,38 @@ serial_0_pins: serial0-state {
> drive-strength = <8>;
> bias-pull-up;
> };
> +
> + mdio0_pins: mdio0-state {
> + mux_0 {
This wasn't tested...
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-10 11:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 11:20 [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC Luo Jie
2024-01-10 11:20 ` [PATCH 1/6] arm64: dts: qcom: ipq9574: Add PPE device tree node Luo Jie
2024-01-10 11:40 ` Krzysztof Kozlowski
2024-01-11 15:30 ` Jie Luo
2024-01-11 16:06 ` Dmitry Baryshkov
2024-01-12 14:40 ` Jie Luo
2024-01-12 14:51 ` Krzysztof Kozlowski
2024-01-22 12:58 ` Jie Luo
2024-01-12 15:03 ` Dmitry Baryshkov
2024-01-17 15:10 ` Jie Luo
2024-01-10 11:20 ` [PATCH 2/6] arm64: dts: qcom: ipq5332: " Luo Jie
2024-01-10 11:20 ` [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree Luo Jie
2024-01-10 11:56 ` Krzysztof Kozlowski [this message]
2024-01-12 16:11 ` Jie Luo
2024-01-10 13:35 ` Andrew Lunn
2024-01-11 15:59 ` Jie Luo
2024-01-11 16:13 ` Dmitry Baryshkov
2024-01-12 15:58 ` Jie Luo
2024-01-11 16:30 ` Andrew Lunn
2024-01-12 16:05 ` Jie Luo
2024-01-16 22:56 ` Andrew Lunn
2024-01-17 15:10 ` Jie Luo
2024-01-11 16:43 ` Krzysztof Kozlowski
2024-01-10 11:20 ` [PATCH 4/6] arm64: dts: qcom: ipq9574: " Luo Jie
2024-01-10 11:20 ` [PATCH 5/6] arm64: dts: qcom: ipq5332: Add RDP441 board " Luo Jie
2024-01-10 11:57 ` Krzysztof Kozlowski
2024-01-17 15:16 ` Lei Wei
2024-01-10 11:20 ` [PATCH 6/6] arm64: dts: qcom: ipq9574: Add RDP433 " Luo Jie
2024-01-12 15:05 ` Dmitry Baryshkov
2024-01-17 15:12 ` Lei Wei
2024-01-10 11:32 ` [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC Konrad Dybcio
2024-01-12 14:55 ` Jie Luo
2024-01-10 12:13 ` Krzysztof Kozlowski
2024-01-12 15:00 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b44a04d-3d04-4fdb-a51c-b0e4b72af558@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_soni@quicinc.com \
--cc=quic_souravp@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).