From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8ECC10F1B for ; Sat, 10 Dec 2022 14:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiLJOZS (ORCPT ); Sat, 10 Dec 2022 09:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbiLJOZO (ORCPT ); Sat, 10 Dec 2022 09:25:14 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE991A39F for ; Sat, 10 Dec 2022 06:25:13 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id b3so11419666lfv.2 for ; Sat, 10 Dec 2022 06:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n8agtrCqEykAcmFlo/cEntor3G0kQRJHu7WxxefGUlQ=; b=hjtLOZXj9dsefoVKt8/L1pyOR+8qga4swUnDyduwYDYKCMZBPhIz18jQbo1nLFcItg SNKrFY2uC8ujQ5jgsZHyoFzIg6SkEihwWrfOULhVttIFoK7Ia+iWQnuRuPX8+7XI/yLf 4F7OOoqXqk02T6P27tUUlWP3S4oXeLghCsLRiJ/jlEZD4YAtGm6gRc1HQpC0dy2ZMXkL 8adc6w0kDUJ++ANEB6o7txXiGuXNye23v3KTeKMzEVQdMUtu3fAH6UcAJMGqwXrFkL+c 85sF/1ODdXRS07sJMWobDDFNzxYdmcnM/fsmxO+yIfe5AYrBG8yGB+o3WbjM1KeDAk3f ZhVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n8agtrCqEykAcmFlo/cEntor3G0kQRJHu7WxxefGUlQ=; b=JIYDL+A7WYf13WOyhmc865SKPVsZCM5CDAL+N/x67jg0tq15SH5lOr01rJnntsXtSF r4EwKX1oD6rm0N9br6MgSSS6POZRNxZOV3PNbzJLtFIk75wU9YVe261fA1p+NdKWLNdo MBx81Hfhya6M8A9hWMS3Tj1aQu4IchEK0mSkOQSIVEFuPkIhy06q9F+NXJGLBLZVvNJQ 5ZVPXthJpxAuvGNOBa1eJybuNxvgeHnOfBSgXetUZH6GnevoBrY9Hpf0pfEEcYNxbD0G CJGTQRarLvsGAH/egYrbY99Qi0sEwr75L08zfgMPvCeTFs0HB1EmRKNf2gYRRzsPj9nl cPsA== X-Gm-Message-State: ANoB5pliPOmqmDKCRJ1Bfulc9kL10YWQUEd9Ee/5zaPMtnOXq8r4KjkH 6WRI3aGggXxp99G4Ljb8ukR/alN6VMCjvmf1 X-Google-Smtp-Source: AA0mqf4vHKTyhpnMP+Q9OIAYTFeC5sHj/OnLmOVhrYDvrG1t3X9YGv5wDi2pQDFTy45xDKtf3XNmaw== X-Received: by 2002:a05:6512:e99:b0:4b5:adae:b6be with SMTP id bi25-20020a0565120e9900b004b5adaeb6bemr3949619lfb.42.1670682311618; Sat, 10 Dec 2022 06:25:11 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id t6-20020a056512208600b004b55e16931fsm737629lfr.259.2022.12.10.06.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 06:25:11 -0800 (PST) Message-ID: <9b57549f-b74a-25f5-e645-f2602199f35b@linaro.org> Date: Sat, 10 Dec 2022 15:25:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH] arm64: dts: qcom: Use plural _gpios node label for PMIC gpios To: Krzysztof Kozlowski , Marijn Suijten , phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Luca Weiss , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221209220450.1793421-1-marijn.suijten@somainline.org> <714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <714ac62a-7bab-e16e-e3b6-bdd86e422699@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10.12.2022 11:50, Krzysztof Kozlowski wrote: > On 09/12/2022 23:04, Marijn Suijten wrote: >> The gpio node in PMIC dts'es define access to multiple GPIOs. Most Qcom >> PMICs were already using the plural _gpios label to point to this node, >> but a few PMICs were left behind including the recently-pulled >> pm(i)8950. >> >> Rename it from *_gpio to *_gpios for pm6125, pm6150(l), pm8005, >> pm(i)8950, and pm(i)8998. >> >> Signed-off-by: Marijn Suijten >> >> --- >> >> This was brought up for discussion in [1] but hasn't seen any relevant >> reply, unfortunately. > > This is just a label, it does not matter. Why changing all exisitng > files? I don't think it was a part of previous discussions... > > To me it is unneeded churn. IMHO it's beneficial, as when working on different platforms I have to waste time checking or being told by the compiler that &pm8xxx_gpios doesn't exist and then I have to think why and realize it's just not named consistently.. Konrad > >> >> [1]: https://lore.kernel.org/linux-arm-msm/20221104234435.xwjpwfxs73puvfca@SoMainline.org/ >> --- >> arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts | 8 ++++---- >> .../dts/qcom/msm8998-oneplus-cheeseburger.dts | 4 ++-- >> .../boot/dts/qcom/msm8998-oneplus-common.dtsi | 6 +++--- >> .../qcom/msm8998-sony-xperia-yoshino-maple.dts | 4 ++-- >> .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi | 16 ++++++++-------- >> .../arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 4 ++-- >> arch/arm64/boot/dts/qcom/pm6125.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pm6150.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pm6150l.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pm8005.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pm8950.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pm8998.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 4 ++-- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4 ++-- >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 16 ++++++++-------- >> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 4 ++-- >> .../boot/dts/qcom/sdm845-oneplus-common.dtsi | 6 +++--- >> .../arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 4 ++-- >> .../boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 2 +- >> .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 ++-- >> .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 ++-- >> .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 2 +- >> 25 files changed, 64 insertions(+), 64 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts >> index 310f7a2df1e8..0e273938b59d 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts >> +++ b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts >> @@ -113,7 +113,7 @@ gpio-keys { >> <&cam_snapshot_pin_a>; >> button-vol-up { >> label = "Volume Up"; >> - gpios = <&pm8998_gpio 6 GPIO_ACTIVE_LOW>; >> + gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>; >> linux,input-type = ; >> linux,code = ; > > Best regards, > Krzysztof >