From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044BDC7EE22 for ; Mon, 8 May 2023 20:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233496AbjEHUCX (ORCPT ); Mon, 8 May 2023 16:02:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232525AbjEHUCV (ORCPT ); Mon, 8 May 2023 16:02:21 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C8AC44AA for ; Mon, 8 May 2023 13:02:14 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9661047f8b8so501016066b.0 for ; Mon, 08 May 2023 13:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683576133; x=1686168133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lAtYseLpXxuBkVxFlbQ8laerKtW1IS2FwFjnYIf67Ew=; b=HrbuCNqRpGjYUk98SN1qVGL7DcEPo8uLKF7tJOUQYAXRJIlclZT2/8zUA81YeCGZGa 5lxcnMX6CYataSzjiwHpRvFjYHExxSYyn/lREd4L26wJxN4Qo9a8XWbASAIVakgCtGzf ZAaEdfLnknO5gnH4p2gbmxstXjJI5+IlpUYmivhhvawZsVBXCks8ZU4PgnDkmwpc7JeT Ih/bSh/PsDGTzH0dW9w71qKAzE1YiBzgMXFHPrlF9DFhmb31mqmz1D06HVPk17l28KwP I4r+iF6OPnnXSGIOTEMUsRZAS2At06NP8qQGH95CzT6WprAGbzNHotDv4RB7cjimEdV9 3fiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683576133; x=1686168133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lAtYseLpXxuBkVxFlbQ8laerKtW1IS2FwFjnYIf67Ew=; b=aSv+UylD9MNvrbzVc1lFSYezRVI8YzjMvZbgQOp3icfjZ75VvptQcs/Ay6+GpgKVAc ZuRAHWCnFEjr68p/mRUm4v62HYbK5zn5PThbDE8t+ppPow4BI52pqCROgfnb2N0e8jry tGINq8t99Qv8j7DbB3+faT4+gMoNbRvfK1rHzu8+1Xu3tfxmaw8NQLhV16IdTN/r7meC Jeyld421CSfz/IxDulgOXzjgh8pptN+/Q1seOdVh3CM41LlSEZV2Ok0OqXYomF7P6+H4 WNwb2CgoCGXCCbdPbzDQVW/BZETxxi0BjvCXXvaL0eWYRU1Mp2keRm7kwy1V5Es2SpAU aWkg== X-Gm-Message-State: AC+VfDz/CX3iHguPBu75Sn7C4nBwQy1dbeU/tmYzAdae7loMT4LtgY9j Osd5JaVafJ9fxFTbluLJ6391bA== X-Google-Smtp-Source: ACHHUZ6VNPRKEgr7OuCdHtimURoftvfdyzlJfcJSBfAQGPgaV7H8oz4a1Kp6taoPOYmL7Bq/1nOfiQ== X-Received: by 2002:a17:907:97ce:b0:94e:4523:b0d8 with SMTP id js14-20020a17090797ce00b0094e4523b0d8mr9960088ejc.73.1683576132774; Mon, 08 May 2023 13:02:12 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d19b:4e0f:cfe4:a1ac? ([2a02:810d:15c0:828:d19b:4e0f:cfe4:a1ac]) by smtp.gmail.com with ESMTPSA id ca21-20020a170906a3d500b00965a52d2bf6sm373253ejb.88.2023.05.08.13.02.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 13:02:12 -0700 (PDT) Message-ID: <9b629b5e-9d49-98a0-abca-75e68abf425b@linaro.org> Date: Mon, 8 May 2023 22:02:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 6/7] dt-bindings: mfd: max77658: Add ADI MAX77658 Content-Language: en-US To: Zeynep Arslanbenzer , lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sre@kernel.org, lgirdwood@gmail.com, broonie@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Nurettin Bolucu References: <20230508131045.9399-1-Zeynep.Arslanbenzer@analog.com> <20230508131045.9399-7-Zeynep.Arslanbenzer@analog.com> From: Krzysztof Kozlowski In-Reply-To: <20230508131045.9399-7-Zeynep.Arslanbenzer@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 15:10, Zeynep Arslanbenzer wrote: > Add ADI MAX77658 devicetree document. > > Signed-off-by: Nurettin Bolucu > Signed-off-by: Zeynep Arslanbenzer > --- > .../devicetree/bindings/mfd/adi,max77658.yaml | 160 ++++++++++++++++++ > 1 file changed, 160 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77658.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77658.yaml b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml > new file mode 100644 > index 000000000000..4d6d87cd4b52 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77658.yaml > @@ -0,0 +1,160 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77658.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77643/54/58/59 PMIC from ADI > + > +maintainers: > + - Nurettin Bolucu > + - Zeynep Arslanbenzer > + > +description: | > + MAX77643, MAX77654, MAX77658 and MAX77659 devices are a family of ADI PMICs > + providing battery charging and power supply solutions for > + low-power applications. > + > + MAX77643 is a Power Management IC with 1 LDO regulator. > + > + MAX77654 is a Power Management IC with 2 LDO regulators and 1 charger. > + > + MAX77658 is a Power Management IC with 2 LDO regulators, 1 charger > + and 1 fuel gauge. > + > + MAX77659 is a Power Management IC with 1 LDO regulator and 1 charger. > + > +properties: > + compatible: > + enum: > + - adi,max77643 > + - adi,max77654 > + - adi,max77658 > + - adi,max77659 > + > + reg: > + items: > + - enum: [0x40, 0x48] > + > + interrupts: > + maxItems: 1 > + > + charger: > + $ref: /schemas/power/supply/adi,max77658-charger.yaml > + > + fuel-gauge: > + $ref: /schemas/power/supply/adi,max77658-battery.yaml > + > + regulators: > + type: object > + > + description: > + The regulators is represented as a sub-node of the PMIC node on the device tree. > + > + patternProperties: > + "^LDO[01]$": lowercase > + type: object > + $ref: /schemas/regulator/regulator.yaml > + additionalProperties: false > + description: > + LDO regulator > + > + properties: > + regulator-always-on: true > + regulator-boot-on: true Why nothing else is allowed? You have different voltages, so how can you configure their constraints if you do not allow them to be configured? Drop all properties and use unevaluatedProperties.. > + > + additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - adi,max77643 > + - adi,max77654 > + - adi,max77658 > + > + then: > + properties: > + reg: > + items: > + - const: 0x48 > + > + else: > + properties: > + reg: > + items: > + - const: 0x40 - if: ... then: properties: regulators: properties: LDO1: false > + > +required: > + - compatible > + - reg > + - interrupts Put required before allOf. > + > +additionalProperties: false > + > +examples: > + - | > + battery: battery-cell { > + compatible = "simple-battery"; > + alert-celsius = <0 100>; > + constant-charge-current-max-microamp = <15000>; > + }; > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@48 { > + compatible = "adi,max77658"; > + reg = <0x48>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + charger { > + compatible = "adi,max77658-charger"; > + monitored-battery = <&battery>; > + adi,input-current-limit-microamp = <475000>; > + }; > + regulators { > + LDO0 { > + regulator-boot-on; > + regulator-always-on; > + }; > + LDO1 { > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + fuel-gauge { > + compatible = "adi,max77658-battery"; > + monitored-battery = <&battery>; > + adi,valrt-min-microvolt = <0>; > + adi,valrt-max-microvolt = <5100000>; > + adi,ialrt-min-microamp = <(-5000)>; > + adi,ialrt-max-microamp = <5000>; > + }; > + }; > + }; > + > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@40 { > + compatible = "adi,max77659"; > + reg = <0x40>; > + interrupt-parent = <&gpio>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + charger { > + compatible = "adi,max77659-charger"; > + monitored-battery = <&battery>; > + }; > + regulators { > + LDO0 { > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > + }; Best regards, Krzysztof