From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ADA5441600 for ; Tue, 28 Jul 2026 13:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785245683; cv=none; b=aFR/Wv6YvHcZDEJ24h83WTPzg3Jp74VRdFqvAdflInhVsoBP1/LP8kpX7VGHOQw/grwjJPgjQ9TMxIUwQqjEu83bQH3gTynUmmju3OhEPcYUGxKOWRGCzvOwS5Ho+TINJ5NEkVoymioriRYPvy/ps54Fef/TAOM6LI2dnd1PX/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785245683; c=relaxed/simple; bh=GNFioT5Go4+A2iCqPdYE4MF6fqEa92pWZK+ljRe2ivk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QjmoalP8vXlvAicoN6rFWkdG+fgpZvrWzGvi6bYaaYQN1jSxMWJ8GTzWKik9oGRxtKm/jEbkCqcmSQzuoCmm+H5FbT8U21BDRlg4eGxlsZeq/GP3SuEYy3ugAKWk1pmTmZrlSVLkH4LNxb4Qs5fYjAwv2i3oQDPbsC88w8qZ5Hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=iyIwyQOP; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="iyIwyQOP" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-9063b380982so38122966d6.0 for ; Tue, 28 Jul 2026 06:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1785245677; x=1785850477; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XzGCbFXxJEuGYSs3c0juxd6AOVKDvi6DBrR61H9y/ak=; b=iyIwyQOPfrkNqOivvOHtBOKA+b9LKLNLCUukLsmgvodu++4vXsXc/Zq4XEs3AwZNIJ oq2FwusW0svmmsgRIHQz0YJpFbjuStd1lnKMlWne/RmpNuHb19zuKC28xd3kWpX6gG+y Q/iSXQ4iXbZ1PBu7OjCHOmIHAYBquRB3mk4tvUcIg9KGVeWJdajKvxzO6trwCLxMKAW1 VMp1uRhkjBiuawpJw0q+iSjkZ0yWr4EmnYsZk56AP9kaMRgrKflpAJ37tJD3At8PzYnH jDAm9sroIS7XxwyJ/Ajn+kj/YXEmFfkEbr1ESZlRatEz7YnhIywDrrJb+JF9q5xwhLsM HDRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785245677; x=1785850477; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XzGCbFXxJEuGYSs3c0juxd6AOVKDvi6DBrR61H9y/ak=; b=HHI5QaJs1h/bvhuaNEWSKsNAPC0yUGkjhuNeLv8UTgWJ+Ddv6NEomVTQ7GBB56AzKg s3WRsgAklYTB0S1MOSLqTkn8pR3xdeYi8bnRRuVM4399uN5ecvEMrEX0S6aQQ+SvcbZo Esb8Wu39yKvsRHIht07aAfzseYY7aqaCxy/Dh/Rt6BfxyIraQYXkf6ByZkbNbj3gFrx+ zVL+kNGa7aPTeDo16FIAGuCjOtnhMJZWvgjX9y94Ic7ZOrX2Pe5LY95pvWXO20JGQdkE Oi5VASRjJqdrq5yiQD3c5z2ElpCKT8xAjGFobUUiibZGjDaphtGlW2SdLiFfn3zLI5LM WIow== X-Forwarded-Encrypted: i=1; AHgh+RpD65MUO04eDiX/idEDsYMpufGirV2AFwc2osrGXXghbNnc2yO63nvvEGcyzg2DhNYQMi25vltT7hb8@vger.kernel.org X-Gm-Message-State: AOJu0YzbO8tH8vxRt05O1nAQJS5zfpvWScnQ8rJYE7nlit75fNaeP+lA a0vBDCHUsyfcBYum6RnTQjNtyKUWAPVIj6X+TZxGxlZc03V/DsJXd1BnLp7+YRwGTaM= X-Gm-Gg: AR+sD1368jhCIWdg8IJSHLi9TpVU1gK2jTex1jGnegQQE7HFRtugIf5ytMCEy0/kJbd I9P2+ttR9i2/FbbvySTUM06k63yg/KVkDT+uzu/jpV6C1BGtwHZYBpXagrm+lDJjMEnahTnydXF UQ+ycAxcF84PD9Tiy6v6ZNlEfclJWcXOc3U4n8QaIO+FTugMdwNj0SKNWSnulqSyIZdrxnPTY0t joAcHNnNMRIlWLTPK+iozGRvEmxlhWevHW0nfxeq9jCiVvkEgzE41bbY1qzY3XivcUbTV+6/Fs/ yPfZpY5frOB6N/weO4PAudgKnY7eY2Mpi9RnlzSKKds/TDu6cRw4IONHtqOQa/4UnrnBXU0t0WR UkCHISYednkyYeWYO2AmxgU5h82CWD5SC1E1jmTAqr3iuO0hkPOBht1CQ1/B+j7e2j4OIwj1w4l dW8dkdw/QCotp3Hh+dkoR2XqVYRoadK0Jirx9apbpkb1qAPlsHmufYak+mwJ6L X-Received: by 2002:a05:620a:4693:b0:92e:e2fc:26d3 with SMTP id af79cd13be357-9330272f6b0mr228855185a.46.1785245677388; Tue, 28 Jul 2026 06:34:37 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-932de6523c4sm844235885a.34.2026.07.28.06.34.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 06:34:36 -0700 (PDT) Message-ID: <9b7cc38c-83d0-48fb-9282-b8c8efd2ae21@riscstar.com> Date: Tue, 28 Jul 2026 08:34:34 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] PCI/pwrctrl: tc9563: Skip Tx amplitude and DFE tuning for DSP3 To: Manivannan Sadhasivam Cc: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Chaitanya Chundru , Bartosz Golaszewski , Bjorn Andersson , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260725-tc9563-fix-v1-0-ec4286e31331@oss.qualcomm.com> <20260725-tc9563-fix-v1-4-ec4286e31331@oss.qualcomm.com> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/28/26 8:25 AM, Manivannan Sadhasivam wrote: > On Mon, Jul 27, 2026 at 10:59:11AM -0500, Alex Elder wrote: >> On 7/25/26 3:59 AM, Manivannan Sadhasivam via B4 Relay wrote: >>> From: Manivannan Sadhasivam >>> >>> DSP3 doesn't support tuning Tx amplitude and DFE settings. So just skip >>> the setting if DT has passed the tuning properties. There is no need to >>> error out the whole driver because of it. >>> >>> Fixes: 4c9c7be47310 ("PCI: pwrctrl: Add power control driver for TC9563") >>> Signed-off-by: Manivannan Sadhasivam >> >> So to keep things simple, tc9563_pwrctrl_parse_device_dt() is called >> for all downstream ports but you ignore the setting (with a warning) >> for those that do not apply to DSP3. >> >> What about tc9563_pwrctrl_set_nfts()? >> > > Good catch! I missed adding the check for N_FTS as well: In case you need it: Reviewed-by: Alex Elder > > ``` > diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > index 9d869483b6b3..978907aa0ce5 100644 > --- a/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > +++ b/drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c > @@ -410,11 +410,17 @@ static int tc9563_pwrctrl_set_nfts(struct tc9563_pwrctrl *tc9563, > {TC9563_NFTS_2_5_GT, nfts[0]}, > {TC9563_NFTS_5_GT, nfts[1]}, > }; > + struct device *dev = tc9563->pwrctrl.dev; > int ret; > > if (!nfts[0]) > return 0; > > + if (port == TC9563_VDSP) { > + dev_dbg(dev, "N_FTS tuning not supported for VDSP\n"); > + return 0; > + } > + > ret = tc9563_pwrctrl_i2c_write(tc9563->client, TC9563_PORT_SELECT, > BIT(port)); > if (ret) > ``` > > @Bjorn: Could you please amend the above diff with this commit? > > - Mani >