From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Ming Qian (OSS)" <ming.qian@oss.nxp.com>,
mirela.rabulea@oss.nxp.com, robh+dt@kernel.org,
shawnguo@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com,
tao.jiang_2@nxp.com, ming.qian@nxp.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 3/3] media: imx-jpeg: Add vendor prefix in slot property
Date: Thu, 19 Oct 2023 09:14:01 +0200 [thread overview]
Message-ID: <9b853b5f-b3e6-4aea-b99a-51a490a29f9d@linaro.org> (raw)
In-Reply-To: <be1f8907582ea344f8826f7888b277534859e0c4.1697597713.git.ming.qian@nxp.com>
On 19/10/2023 04:48, Ming Qian (OSS) wrote:
> From: Ming Qian <ming.qian@nxp.com>
>
> The slot property isn't generic property, add vendor prefix. Change the
> property name to nxp,slot.
>
> Fixes: 53ebeea50599 ("media: imx-jpeg: Support to assign slot for encoder/decoder")
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> ---
> v5
> - add vender prefix, change property slot to nxp,slot
>
> v4
> - nothing changed here, just modify the bindings and dts
>
> v3
> - nothing changed here, just modify the bindings and dts
>
> v2
> - nothing changed here, just modify the bindings and dts
>
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index 64112b63298c..f8b99a292ad1 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2762,7 +2762,7 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
> if (IS_ERR(jpeg->base_reg))
> return PTR_ERR(jpeg->base_reg);
>
> - ret = of_property_read_u32_index(pdev->dev.of_node, "slot", 0, &jpeg->slot_data.slot);
How did it appear in the code and in the DTS without bindings...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-19 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 2:47 [PATCH v5 0/3] media: imx-jpeg: Assign a single slot Ming Qian (OSS)
2023-10-19 2:48 ` [PATCH v5 1/3] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder Ming Qian (OSS)
2023-10-19 7:19 ` Krzysztof Kozlowski
2023-10-19 7:47 ` ming qian
2023-10-20 5:38 ` ming qian
2023-10-20 11:14 ` Krzysztof Kozlowski
2023-10-19 2:48 ` [PATCH v5 2/3] arm64: dts: imx8-ss-img: Add vendor prefix in slot property Ming Qian (OSS)
2023-10-19 2:48 ` [PATCH v5 3/3] media: imx-jpeg: " Ming Qian (OSS)
2023-10-19 7:14 ` Krzysztof Kozlowski [this message]
2023-10-19 7:41 ` ming qian
2023-10-20 11:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b853b5f-b3e6-4aea-b99a-51a490a29f9d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.zhou@nxp.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=ming.qian@oss.nxp.com \
--cc=mirela.rabulea@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tao.jiang_2@nxp.com \
--cc=xiahong.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).