From: Philipp Zabel <p.zabel@pengutronix.de>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>,
Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Frank Li <Frank.Li@nxp.com>
Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v4 1/8] reset: imx8mp-audiomix: Fix bad mask values
Date: Wed, 05 Nov 2025 16:16:09 +0100 [thread overview]
Message-ID: <9baa4aa8c3e5b15cc23b6915ae1466fdeba75291.camel@pengutronix.de> (raw)
In-Reply-To: <20251104120301.913-2-laurentiumihalcea111@gmail.com>
On Di, 2025-11-04 at 04:02 -0800, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> As per the i.MX8MP TRM, section 14.2 "AUDIO_BLK_CTRL", table 14.2.3.1.1
> "memory map", the definition of the EARC control register shows that the
> EARC controller software reset is controlled via bit 0, while the EARC PHY
> software reset is controlled via bit 1.
>
> This means that the current definitions of IMX8MP_AUDIOMIX_EARC_RESET_MASK
> and IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK are wrong since their values would
> imply that the EARC controller software reset is controlled via bit 1 and
> the EARC PHY software reset is controlled via bit 2. Fix them.
>
> Fixes: a83bc87cd30a ("reset: imx8mp-audiomix: Prepare the code for more reset bits")
> Cc: stable@vger.kernel.org
> Reviewed-by: Shengjiu Wang <shengjiu.wang@gmail.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Applied patch 1 to reset/fixes, thanks!
[1/8] reset: imx8mp-audiomix: Fix bad mask values
https://git.pengutronix.de/cgit/pza/linux/commit/?id=997c06330fd5
regards
Philipp
next prev parent reply other threads:[~2025-11-05 15:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 12:02 [PATCH v4 0/8] Add support for i.MX8ULP's SIM LPAV Laurentiu Mihalcea
2025-11-04 12:02 ` [PATCH v4 1/8] reset: imx8mp-audiomix: Fix bad mask values Laurentiu Mihalcea
2025-11-05 15:16 ` Philipp Zabel [this message]
2025-11-04 12:02 ` [PATCH v4 2/8] dt-bindings: clock: document 8ULP's SIM LPAV Laurentiu Mihalcea
2025-11-04 12:02 ` [PATCH v4 3/8] clk: imx: add driver for imx8ulp's sim lpav Laurentiu Mihalcea
2025-11-04 12:45 ` Peng Fan
2025-11-05 9:36 ` Daniel Baluta
2025-11-04 12:02 ` [PATCH v4 4/8] reset: imx8mp-audiomix: Drop unneeded macros Laurentiu Mihalcea
2025-11-05 15:10 ` Philipp Zabel
2025-11-04 12:02 ` [PATCH v4 5/8] reset: imx8mp-audiomix: Switch to using regmap API Laurentiu Mihalcea
2025-11-04 16:44 ` Frank Li
2025-11-05 11:53 ` Laurentiu Mihalcea
2025-11-05 15:23 ` Frank Li
2025-11-05 15:10 ` Philipp Zabel
2025-11-04 12:02 ` [PATCH v4 6/8] reset: imx8mp-audiomix: Extend the driver usage Laurentiu Mihalcea
2025-11-04 16:46 ` Frank Li
2025-11-04 12:03 ` [PATCH v4 7/8] reset: imx8mp-audiomix: Support i.MX8ULP SIM LPAV Laurentiu Mihalcea
2025-11-04 12:03 ` [PATCH v4 8/8] arm64: dts: imx8ulp: add sim lpav node Laurentiu Mihalcea
2025-11-11 16:05 ` [PATCH v4 0/8] Add support for i.MX8ULP's SIM LPAV Abel Vesa
2025-11-11 16:10 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9baa4aa8c3e5b15cc23b6915ae1466fdeba75291.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Frank.Li@nxp.com \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurentiumihalcea111@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox