From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/2] arm64: dts: renesas: condor: add I2C0 support Date: Tue, 29 May 2018 18:46:10 +0300 Message-ID: <9bc27b57-cf26-3b03-6ec4-1e9788a46426@cogentembedded.com> References: <61f6f4a4-e55c-06e0-cba1-7d90a556950a@cogentembedded.com> <20180529131012.ohyqwmiaxiiw6noi@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180529131012.ohyqwmiaxiiw6noi@verge.net.au> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Simon Horman Cc: Mark Rutland , devicetree@vger.kernel.org, Magnus Damm , Catalin Marinas , Will Deacon , linux-renesas-soc@vger.kernel.org, Rob Herring , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hello! On 05/29/2018 04:10 PM, Simon Horman wrote: >> Define the Condor board dependent part of the I2C0 device node. >> >> The I2C0 bus is populated by 2 ON Semiconductor PCA9654 I/O expanders >> and Analog Devices ADV7511W HDMI transmitter (but we're only describing >> the former chips now). >> >> Signed-off-by: Sergei Shtylyov >> >> --- >> arch/arm64/boot/dts/renesas/r8a77980-condor.dts | 27 ++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts >> =================================================================== >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980-condor.dts >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980-condor.dts >> @@ -80,6 +80,28 @@ >> clock-frequency = <32768>; >> }; >> >> +&i2c0 { >> + pinctrl-0 = <&i2c0_pins>; >> + pinctrl-names = "default"; >> + >> + status = "okay"; >> + clock-frequency = <400000>; >> + >> + io_expander0: gpio@20 { > > Hi Sergei, > > I'm a little confused about where 0x20 and 0x21 are derived from. > Could you explain a little? r-carv3h_system_evaluation_board_rev020.pdf, pp. 16-17, lower left corners. The schematics gives the 8-bit read/write addresses but we use uniform 7-bit I2C address in DTs. >> + compatible = "onnn,pca9654"; >> + reg = <0x20>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + }; >> + >> + io_expander1: gpio@21 { >> + compatible = "onnn,pca9654"; >> + reg = <0x21>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + }; >> +}; >> + >> &mmc0 { >> pinctrl-0 = <&mmc_pins>; >> pinctrl-1 = <&mmc_pins_uhs>;