From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: ~okias/devicetree@lists.sr.ht, Rob Herring <robh@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips
Date: Sat, 7 May 2022 19:22:23 +0200 [thread overview]
Message-ID: <9bcdec7e-2b09-56ac-f798-1c3971a87f46@linaro.org> (raw)
In-Reply-To: <20220111212310.97566-1-david@ixit.cz>
On 11/01/2022 22:23, David Heidelberg wrote:
> Parse compatible as expected for modern QCOMs.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: ['qcom,apss-wdt-sdm845', 'qcom,kpss-wdt'] is too long
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: Additional items are not allowed ('qcom,kpss-wdt' was unexpected)
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> v2:
> - updated compatible list as two compatibles has been added upstream
> -> resolve merge conflict
> ---
> .../bindings/watchdog/qcom-wdt.yaml | 37 +++++++++++--------
> 1 file changed, 21 insertions(+), 16 deletions(-)
It seems this patch received three reviews but was not picked up. David,
do you plan to work on this?
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 16c6f82a13ca..4ff8c59c59ab 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -14,22 +14,27 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - qcom,apss-wdt-qcs404
> - - qcom,apss-wdt-sc7180
> - - qcom,apss-wdt-sc7280
> - - qcom,apss-wdt-sdm845
> - - qcom,apss-wdt-sdx55
> - - qcom,apss-wdt-sm6350
> - - qcom,apss-wdt-sm8150
> - - qcom,apss-wdt-sm8250
> - - qcom,kpss-timer
> - - qcom,kpss-wdt
> - - qcom,kpss-wdt-apq8064
> - - qcom,kpss-wdt-ipq4019
> - - qcom,kpss-wdt-ipq8064
> - - qcom,kpss-wdt-msm8960
> - - qcom,scss-timer
> + oneOf:
> + - items:
> + - enum:
> + - qcom,apss-wdt-qcs404
> + - qcom,apss-wdt-sc7180
> + - qcom,apss-wdt-sc7280
> + - qcom,apss-wdt-sdm845
> + - qcom,apss-wdt-sdx55
> + - qcom,apss-wdt-sm6350
> + - qcom,apss-wdt-sm8150
> + - qcom,apss-wdt-sm8250
> + - const: qcom,kpss-wdt
> + - items:
> + - enum:
> + - qcom,kpss-wdt
> + - qcom,kpss-timer
> + - qcom,kpss-wdt-apq8064
> + - qcom,kpss-wdt-ipq4019
> + - qcom,kpss-wdt-ipq8064
> + - qcom,kpss-wdt-msm8960
These do not look correct without appropriate fallback.
> + - qcom,scss-timer
>
> reg:
> maxItems: 1
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-07 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 21:23 [PATCH v2] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips David Heidelberg
2022-01-17 17:45 ` Guenter Roeck
2022-05-07 17:22 ` Krzysztof Kozlowski [this message]
2022-05-07 19:30 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bcdec7e-2b09-56ac-f798-1c3971a87f46@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=wim@linux-watchdog.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).