From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A59F43254A5 for ; Wed, 25 Mar 2026 10:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774433547; cv=none; b=hc3NUcy4ZBaNISOiiBnZyVfDpViVI+QC9/gFBRXkvj1jLBQRZdv2/t1GAUUZMOCYLPz6C+eaYlZ7jnxsW4s1BwX23OXYzCIPRdfyVDJt9x3UP6viXquu4i/vLkC31XNa6l7nKwzfuCxn60MXB9SZKO1R5MYp3d0rzI9eYYnCi5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774433547; c=relaxed/simple; bh=m56/b3WOzdczHaxO3PWQ3LHZIR79H+h2yCAj5xOJYe0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MYy6noLmqzsoI3eZw+x5pzpA3ysXjVxQtMj9Zdj/vu/91QXMNSk/RRyEo0ST/XNaspFyNMwuLEYIpbMxx/wCS7I1ZX/hgjuevCsV2u52tQXhwR+bEsI9S+sp/T72TUrbJ+HV33dte03nHUJKjEQaePLJfIrczxZuJf3onh/3ZGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=avc3bssr; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="avc3bssr" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4870206f73bso27858845e9.3 for ; Wed, 25 Mar 2026 03:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774433544; x=1775038344; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=m56/b3WOzdczHaxO3PWQ3LHZIR79H+h2yCAj5xOJYe0=; b=avc3bssreIgFfAmdzrvzIr/Tf0xQ5t5dN+pgfWGhW8TlGyuDhQu385sDwBo9iYv65m F3vBh9M+VfI2ywySrtXISxuUxZnh3t3/MjuVBFbISOx8XRSiVGGS7LIjtzRtmfV/7FNK zcmE+HhMM9YrfKw2eLjAjSABm1cNthihOdV18QgwPNX+lyIKoCXtpnoI52J9UVZvwKyU IwGw+sV3fSDxumuqECvL4rK5LQeKV/oIjZKJ0Q78oGUbECJPJ4aU1RslBFmilm11Pf3M gRWBH4yx4U7cQxAaaMDfuVyjCjFu0sNvzZ8sf6hw/b95Td+l/4QmMZIhQ77aihwMNzUD yN1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774433544; x=1775038344; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m56/b3WOzdczHaxO3PWQ3LHZIR79H+h2yCAj5xOJYe0=; b=cLVGFH97VI8ximeE749btgPINQ071c/DMuJ780UH+OOkAZPm7spe+5NR9R5L4oUAhl cORVMnfn07BGpKleQVdwq4/dEbrhOeChkuZZQHHWFfluaML750lz7XU4iwhwwNxBmmKx 1oqXkc+q4Z2ArcOvs7IwpagvsFsnLWCbeDwtoeeiLT+/s1x8QmgoSk7xKPMT7K3oDZqa pKQ57qzEKjE/mRgWj3UjMFb98y0PjlzOvgzpkwGGP/V0o/HtXe2lkMX1oY5UBEbcnnsQ pdZd7H2/O1bKTQPawLdciY3/k/DcvmzoyFfEfUnITCvfqN78WJTPbhBTEWRYuvrNgDPl f13g== X-Forwarded-Encrypted: i=1; AJvYcCUOZpgQTkSYScyy1H82/f75nNbrp/qnUKW1r0I3yc4mjnlv/bVOOJNNt8uC0uomprPwJ7SifqLF1ktn@vger.kernel.org X-Gm-Message-State: AOJu0YwN0Aak9nHo4XfIfI6D1AvEv0aYAD35qkmzj3m5ilk2ydZr/1/a spRlnoIR2ScucIF4HtGJc53eorxMnMRgJIj7h6hQEhWwoKJAyLGl5GUN X-Gm-Gg: ATEYQzyi187yTdX4qnY0zLQF171SpR9nmR21wQXX77o2q5VVlGmyFIK/m/O9LV35s+c 1dkNlm9KJ0MMlsDGwzDaKiYegRNlo9mo6wMnrPhceinOnzyn2U64CSUSzdAwZx2X1GtYPTZYL7j kDsKzlAjxojsteOjrzo4Awd8OJ1OERGxZ/JZVEX971nFsx7IuI+nRlce1K7IwBkpbMANLKw4Jbx r14UmLu1zHPBN7/wjopRv8vfwwxLXdZVsHfy7fJAArANRtm2XPbAPTcYyjPKnxIAdInzI3lZpE+ SgY/BhmLfKgTl0QjlvZyi9LqFIErkzW+XW3JU6iPoeoR+kYW4scKmNpNp5w8W2V/7Lkols7Iv0T ZvXmpaJbCkQcJYHj9ZoeXFQo01sWe8vsdZ/t7SsFHDafSS+bMzRp5jstN4L7V4VE013qCO6HfoS XoqXjYD7xPnafwg14+qPMRNe5ZLI+9qKw= X-Received: by 2002:a05:600c:5296:b0:487:13d:4e77 with SMTP id 5b1f17b1804b1-48716067315mr43725525e9.27.1774433543852; Wed, 25 Mar 2026 03:12:23 -0700 (PDT) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871739609csm16267605e9.33.2026.03.25.03.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 03:12:23 -0700 (PDT) Message-ID: <9bd364de66e86c8f94e410cc926775997f85b070.camel@gmail.com> Subject: Re: [PATCH v3 2/2] iio: dac: ad5706r: Add support for AD5706R DAC From: Nuno =?ISO-8859-1?Q?S=E1?= To: "Torreno, Alexis Czezar" , Andy Shevchenko Cc: Lars-Peter Clausen , "Hennerich, Michael" , Jonathan Cameron , David Lechner , "Sa, Nuno" , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 25 Mar 2026 10:13:10 +0000 In-Reply-To: References: <20260318-dev_ad5706r-v3-0-5d078f41e988@analog.com> <20260318-dev_ad5706r-v3-2-5d078f41e988@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-03-25 at 01:07 +0000, Torreno, Alexis Czezar wrote: > > > > > Changes since v1: > > > > > =C2=A0 - Removed PWM, GPIO, clock generator, debugfs, regmap, > > > > > IIO_BUFFER > > > >=20 > > > > Why was regmap removed?! Was it not used? > > >=20 > > > As far as I understand it, regmap also gives access to debugfs. When = I > > > removed debugfs I also added regmap as removed. > >=20 > > Not only debugfs, and it's unrelated to the any custom debugfs interfac= es in > > the driver, it's just a feature out-of-the-box of regmap. > >=20 > > > For the spi write/read I am not using regmap as the device has some > > > features that I think regmap_read/write couldn't support. Namely the > > > variable data width, as the device only accepts exact amount of clock > > > cycles. Future patches will also add variable SPI speed. > >=20 > > We have a lot of flexibility in regmap core. Do you think it can be imp= roved / > > extended to cover the cases like yours? > >=20 >=20 > To neatly summarize, my needs are: (in future patches) > 1. SPI read/write can have different frequencies and runtime changeable > 2. SPI data bits needs to be exactly 8bits or 16bits depending on registe= r width > 3. DAC Device reads SPI command bits [14:12] for communication, not just = chip select >=20 > For regmap to be used > 1. regmap_config would need new read_speed and write_speed entries. > 2. val_bits must now be changeable depending on the need. > 3. I think the read/write_flag_mask can do this. >=20 Do not forget you can just implement your custom regmap_bus which also open= s new "doors". - Nuno S=C3=A1