From: Vignesh R <vigneshr@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 4/4] ARM: dts: dra7: Fix up unaligned access setting for PCIe EP
Date: Thu, 19 Jul 2018 16:24:26 +0530 [thread overview]
Message-ID: <9bdf39d4-d9db-b80f-e3f4-88c3e068c306@ti.com> (raw)
In-Reply-To: <92691b59-1952-b00f-da5b-f308f94aa2b7@ti.com>
Hi Tony,
On Tuesday 17 July 2018 03:25 PM, Kishon Vijay Abraham I wrote:
>
>
> On Wednesday 27 June 2018 05:59 PM, Vignesh R wrote:
>> Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and
>> PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are
>> incorrectly documented in the TRM. In fact, the bit positions are
>> swapped. Update the DT bindings for PCIe EP to reflect the same.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> Shouldn't this be sent to stable fixes?
This patch fixes:
Fixes: d23f3839fe97 ("ARM: dts: DRA7: Add pcie1 dt node for EP mode")
Cc: stable@vger.kernel.org
let me know if this needs to be resent with Fixes tag.
Regards
Vignesh
>
> Thanks
> Kishon
>> ---
>> arch/arm/boot/dts/dra7.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 7bfe7f28e3bd..27ad193e1a87 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -355,7 +355,7 @@
>> ti,hwmods = "pcie1";
>> phys = <&pcie1_phy>;
>> phy-names = "pcie-phy0";
>> - ti,syscon-unaligned-access = <&scm_conf1 0x14 2>;
>> + ti,syscon-unaligned-access = <&scm_conf1 0x14 1>;
>> status = "disabled";
>> };
>> };
>>
prev parent reply other threads:[~2018-07-19 10:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 12:29 [PATCH v2 0/4] pci-dra7xx: Enable errata i870 workaround for RC mode Vignesh R
2018-06-27 12:29 ` [PATCH v2 1/4] dt-bindings: PCI: dra7xx: Add bindings for unaligned access in host mode Vignesh R
2018-06-27 12:29 ` [PATCH v2 2/4] pci: dwc: pci-dra7xx: Enable errata i870 for both EP and RC mode Vignesh R
2018-07-17 9:54 ` Kishon Vijay Abraham I
2018-07-18 11:02 ` Lorenzo Pieralisi
2018-07-19 10:34 ` Vignesh R
2018-07-19 11:15 ` Lorenzo Pieralisi
2018-07-19 15:59 ` Vignesh R
2018-06-27 12:29 ` [PATCH v2 3/4] ARM: dts: dra7: Enable workaround for errata i870 in PCIe host mode Vignesh R
2018-06-27 12:29 ` [PATCH v2 4/4] ARM: dts: dra7: Fix up unaligned access setting for PCIe EP Vignesh R
2018-07-17 9:55 ` Kishon Vijay Abraham I
2018-07-19 10:54 ` Vignesh R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bdf39d4-d9db-b80f-e3f4-88c3e068c306@ti.com \
--to=vigneshr@ti.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).