From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C66C0015E for ; Wed, 26 Jul 2023 22:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229845AbjGZWTE (ORCPT ); Wed, 26 Jul 2023 18:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjGZWTD (ORCPT ); Wed, 26 Jul 2023 18:19:03 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 223E81BFF; Wed, 26 Jul 2023 15:19:01 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id AE4CC24E26F; Thu, 27 Jul 2023 06:18:59 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 27 Jul 2023 06:18:59 +0800 Received: from [192.168.60.107] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 27 Jul 2023 06:18:59 +0800 Message-ID: <9c38930b-4bd9-4956-74c7-3be2915f4676@starfivetech.com> Date: Thu, 27 Jul 2023 06:18:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver Content-Language: en-US To: Bryan O'Donoghue , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia CC: , , , References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-4-jack.zhu@starfivetech.com> From: Jack Zhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bryan, Thank you for your comments. On 2023/7/26 18:58, Bryan O'Donoghue wrote: > On 19/06/2023 12:28, Jack Zhu wrote: >> Add basic platform driver for StarFive Camera Subsystem. > > Another nit here. > > "Add basic driver" isn't a great title. Recommend "Add core driver". > > Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc. > > Use "core" not "basic" to describe this. > Ok, I will modify this title. > --- > bod > -- Regards, Jack Zhu