From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57BAFC4363A for ; Thu, 8 Oct 2020 14:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E293D21789 for ; Thu, 8 Oct 2020 14:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYRqTRYP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730713AbgJHO6j (ORCPT ); Thu, 8 Oct 2020 10:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729833AbgJHO6j (ORCPT ); Thu, 8 Oct 2020 10:58:39 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07635C061755; Thu, 8 Oct 2020 07:58:39 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id y14so4476195pgf.12; Thu, 08 Oct 2020 07:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ooZjKz5uSjTKoQI2IxfmGtOoaA/YElVdEKthcp4JCy0=; b=kYRqTRYPJwu/u/x+JWPji3EJLHY8iHLCu0fp4xrK8eN44hz/EKpsrCwGy2J5jQsqUl 1pmSvEyy75FzbU76a72nI370rkQ5V0ltSuG8uqjwViEvbOA6Y1BdMeodJyl4ywvaa5GI X0aggxGC9vHlDMi7AOLvnaCf/YdyjpXvZwsagPkxvTJfM6tIBlarogipQQi9iEfSV7av eZrACIDjS4Bm6BFPSm7hnhsFT3pgQY9pYlmZ0vveaqcWsYZMQZIhInyPFG8WEcSOPlwD xJqbPsVKBEHObi2GksOrrBOOHg4o2O584suy8PfZUTICerVyOM4cb729k5WJ0qvGpqor DxKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ooZjKz5uSjTKoQI2IxfmGtOoaA/YElVdEKthcp4JCy0=; b=rnAHLTToso4FNdMl8UtPb9jTJ1G0o8TQKLaRe7HwU+X/5MB7hG9OgIPSLG+UkdYU2i zs3+FwrTyfOq9koNNamjlwErY5zDcRCtqQhxncRHPiZst0QQWql9Zkt3qHnyIXKGd0fI zyrsHbTaLVO0D2cRITAcZ9ukv4DURjrVzpFipN5Zi/TGqTbeFwyj4cpM0KeyqHrExXxg SXMrX+cOg+nuR810BEGJEjaec+btnfQNUYiKou1U7FUDNzBPcijiDaAPonMPLGecwGfX sWkaEzCyw0lLl4DsRJHeY3MI2yzwFNMqsHM1pKgZWIPEKDZazueCvcbFhP2+UgqVczjt /3hw== X-Gm-Message-State: AOAM533UhuSEQQppsU3TomxXGnCX01147ERlmqngEWLZRaPehvNezF2v 74/uIGtZdTUK9Q0ypy5A1lk= X-Google-Smtp-Source: ABdhPJy0eL9K5c2FxGv07NPIdvY7W6v4AtwKGIOyCaMbhX2X4MJexS8uTGuygF9J3KZAT6flcWW3hA== X-Received: by 2002:a65:6487:: with SMTP id e7mr7513174pgv.409.1602169118483; Thu, 08 Oct 2020 07:58:38 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id z20sm7718395pfk.199.2020.10.08.07.58.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 07:58:37 -0700 (PDT) Subject: Re: [PATCH 2/3] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7 To: Andrew Lunn , Vivek Unune Cc: devicetree@vger.kernel.org, Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org References: <20201007210327.GE112961@lunn.ch> <20201007220718.GB1972@ubuntu> <20201008003241.GG112961@lunn.ch> From: Florian Fainelli Message-ID: <9c6e4da5-033e-6b30-4525-9f3a7b4ba01f@gmail.com> Date: Thu, 8 Oct 2020 07:58:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201008003241.GG112961@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/7/2020 5:32 PM, Andrew Lunn wrote: >> This router is currently not enabled in Openwrt > > You have to be careful here. Not everything runs OpenWRT. You cannot > break backwards compatibility in mainline, simple as that. You need to > ensure that mainline does not see a change in the CPU port. I don't think this is breaking anything, in premise all 3 CPU interfaces are completely interchangeable, with the notable fact that port 8 happens to have the flow accelerator block available for re-circulation of packets if we wanted to support a NATP offload at some point in the future. Vivek, maybe you can add ports 5 and 7 in the Device Tree and mark them as disabled for now. -- Florian