From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Lin, Meng-Bo" <linmengbo06890@proton.me>, linux-kernel@vger.kernel.org
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/2] arm64: dts: qcom: msm8916-panasonic-eluga-u2: add initial device tree
Date: Wed, 15 Apr 2026 11:01:19 +0200 [thread overview]
Message-ID: <9c76480a-2586-41da-8dc9-37caf0ce9b7d@oss.qualcomm.com> (raw)
In-Reply-To: <20260414184429.168612-3-linmengbo06890@proton.me>
On 4/14/26 8:44 PM, Lin, Meng-Bo wrote:
> Panasonic ELUGA U2 is a phone using the MSM8916 SoC released in 2015.
>
> Add a device tree for with initial support for:
>
> - GPIO keys
> - GPIO LEDs
> - pm8916-vibrator
> - SDHCI (internal and external storage)
> - USB Device Mode
> - UART
> - Regulators
>
> Signed-off-by: "Lin, Meng-Bo" <linmengbo06890@proton.me>
> ---
[...]
> +&pm8916_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> + status = "okay";
nit: let's uniformly keep a \n before 'status' across the file
with Dmitry's comment taken care of:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-04-15 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 18:44 [PATCH 0/2] arm64: dts: qcom: msm8916-panasonic-eluga-u2: add initial device tree Lin, Meng-Bo
2026-04-14 18:44 ` [PATCH 1/2] dt-bindings: qcom: Document panasonic,eluga-u2 Lin, Meng-Bo
2026-04-15 8:07 ` Krzysztof Kozlowski
2026-04-14 18:44 ` [PATCH 2/2] arm64: dts: qcom: msm8916-panasonic-eluga-u2: add initial device tree Lin, Meng-Bo
2026-04-14 19:41 ` Dmitry Baryshkov
2026-04-15 9:01 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c76480a-2586-41da-8dc9-37caf0ce9b7d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linmengbo06890@proton.me \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox